Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Taiwanese Mandarin language #170

Merged
merged 5 commits into from
Jul 14, 2024

Conversation

shinebrillant
Copy link
Contributor

Add Traditional Chinese translation.

@enrique-lozano
Copy link
Owner

Hi! Thanks a lot for contributing! I will review and merge this PR when #166 is resolved.

Please review the file default_categories.json (inside assets/sql), because if you don't put translations there, the category names will be in english.

@shinebrillant
Copy link
Contributor Author

assets/sql/default_categories.json
The language names are arranged differently. Can they be arranged according to /i18n?

@enrique-lozano
Copy link
Owner

Hmm, I don't think I understand you well. To add translations to the categories you just have to add a new key with your language code where you see the names of the categories. In the following way:

image

I think there may be a lot of documentation missing in this regard, I will try to work on it as soon as it is more available.

@shinebrillant
Copy link
Contributor Author

The ordering of en and es is confusing and I feel uncomfortable. Can I change it by the way?
2024-07-10 220023

@enrique-lozano
Copy link
Owner

Oh! I see, yes of couse you can change it! The order doesn't matter in this case, but obviously it looks better to have always the same order, so thanks a lot for pointing this out

Thanks a lot again and sorry for the inconvenience!

@enrique-lozano enrique-lozano changed the base branch from main to develop July 14, 2024 09:19
@enrique-lozano enrique-lozano changed the title Added zh_TW translation. Add Taiwanese Mandarin language Jul 14, 2024
@enrique-lozano enrique-lozano merged commit 216941a into enrique-lozano:develop Jul 14, 2024
@enrique-lozano enrique-lozano self-assigned this Jul 14, 2024
@enrique-lozano enrique-lozano added the type: enhancement New feature or request label Jul 14, 2024
@enrique-lozano enrique-lozano added the Translations Translations, text changes or anything related to localization label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Translations Translations, text changes or anything related to localization type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants