-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New behaviour and animation for the "New transaction" button #275
New behaviour and animation for the "New transaction" button #275
Conversation
The animation was not working, i already fixed it and I'm still testing. Looks good already! Thanks a lot ❤️ |
Thanks a lot @enrique-lozano , I might have not looked into animation part. Thanks for fixing it. Let me know further |
I also just changed the behavior a bit, now the extended version is shown every time we scroll up and not just when we are at the top of the page (like in gmail) |
Please @ARYPROGRAMMER, test the app now (since I made some changes) and tell me if everything works as expected. If so, I will merge the PR 🚀 |
I just tested the app and this lgtm. |
Also, can we add e2e tests so that we don't have to test these functionalities manually every time |
For now I think the optimizations done by you @enrique-lozano works fine on my device and serves the purpose |
That would be awesome, definitely one of the big things missing from the code is testing. There are practically 0 tests in the entire app right now, so starting to introduce some will definitely be a long task. If you want to try it out that would be great, I accept any PR on this :) |
Surely, I would look into this soon |
This PR addresses the Issue discussed here #244 and attempts to close it.