Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New behaviour and animation for the "New transaction" button #275

Conversation

ARYPROGRAMMER
Copy link
Contributor

This PR addresses the Issue discussed here #244 and attempts to close it.

  • Added new behavioral functionality of floating action button
  • Verified testing on real android device
  • All other functionalities kept same

@enrique-lozano enrique-lozano added type: enhancement New feature or request UI / UX Design-related tasks labels Dec 19, 2024
@enrique-lozano enrique-lozano linked an issue Dec 20, 2024 that may be closed by this pull request
4 tasks
@enrique-lozano
Copy link
Owner

enrique-lozano commented Dec 20, 2024

The animation was not working, i already fixed it and I'm still testing. Looks good already!

Thanks a lot ❤️

@ARYPROGRAMMER
Copy link
Contributor Author

The animation was not working, i already fixed it and I'm still testing. Looks good already!

Thanks a lot ❤️

Thanks a lot @enrique-lozano , I might have not looked into animation part. Thanks for fixing it. Let me know further

@enrique-lozano
Copy link
Owner

I also just changed the behavior a bit, now the extended version is shown every time we scroll up and not just when we are at the top of the page (like in gmail)

@enrique-lozano
Copy link
Owner

Please @ARYPROGRAMMER, test the app now (since I made some changes) and tell me if everything works as expected. If so, I will merge the PR 🚀

@ARYPROGRAMMER
Copy link
Contributor Author

Please @ARYPROGRAMMER, test the app now (since I made some changes) and tell me if everything works as expected. If so, I will merge the PR 🚀

I just tested the app and this lgtm.
You can move ahead with the PR

@ARYPROGRAMMER
Copy link
Contributor Author

Please @ARYPROGRAMMER, test the app now (since I made some changes) and tell me if everything works as expected. If so, I will merge the PR 🚀

Also, can we add e2e tests so that we don't have to test these functionalities manually every time

@ARYPROGRAMMER
Copy link
Contributor Author

For now I think the optimizations done by you @enrique-lozano works fine on my device and serves the purpose

@enrique-lozano enrique-lozano changed the title feat: changed transaction floating button behaviour New behaviour and animation for the "New transaction" button Dec 20, 2024
@enrique-lozano enrique-lozano merged commit 0943265 into enrique-lozano:develop Dec 20, 2024
@enrique-lozano
Copy link
Owner

Please @ARYPROGRAMMER, test the app now (since I made some changes) and tell me if everything works as expected. If so, I will merge the PR 🚀

Also, can we add e2e tests so that we don't have to test these functionalities manually every time

That would be awesome, definitely one of the big things missing from the code is testing. There are practically 0 tests in the entire app right now, so starting to introduce some will definitely be a long task. If you want to try it out that would be great, I accept any PR on this :)

@ARYPROGRAMMER
Copy link
Contributor Author

Please @ARYPROGRAMMER, test the app now (since I made some changes) and tell me if everything works as expected. If so, I will merge the PR 🚀

Also, can we add e2e tests so that we don't have to test these functionalities manually every time

That would be awesome, definitely one of the big things missing from the code is testing. There are practically 0 tests in the entire app right now, so starting to introduce some will definitely be a long task. If you want to try it out that would be great, I accept any PR on this :)

Surely, I would look into this soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request UI / UX Design-related tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the new transaction floating button behavior
2 participants