Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CodeQL workflow for automated code scanning #463

Merged
merged 3 commits into from
May 17, 2024

Conversation

k-taro56
Copy link
Contributor

This pull request adds a CodeQL workflow for automated code scanning. The workflow file is included in the .github/workflows directory and is named codeql.yml. The workflow is triggered on push and pull request events on the develop branch, as well as on a weekly schedule. The workflow runs CodeQL analysis on the repository's codebase using the supported languages specified in the matrix. The analysis is performed on either ubuntu-latest or macos-latest runners, depending on the language. The workflow also sets the necessary permissions for the analysis, including read access to security events, packages, actions, and contents.

@k-taro56
Copy link
Contributor Author

Default の CodeQL 有効なんですね
Workflow になったの別になくてもよい感じ

@k-taro56 k-taro56 marked this pull request as draft April 30, 2024 22:33
@k-taro56 k-taro56 force-pushed the feature/add-codeql branch 2 times, most recently from 82c1155 to d5dfc08 Compare May 1, 2024 08:04
@k-taro56 k-taro56 marked this pull request as ready for review May 1, 2024 08:08
Copy link
Owner

@ensan-hcl ensan-hcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます!2点細かいことコメントしました!

.github/workflows/codeql.yml Show resolved Hide resolved
.github/workflows/codeql.yml Show resolved Hide resolved
@k-taro56
Copy link
Contributor Author

k-taro56 commented May 1, 2024

Swift で Warning と Python の Code scanning results でなにか問題がありそう👀

@ensan-hcl
Copy link
Owner

なるほど、それぞれのWarningは別途対応すれば良いので、一旦これでマージしちゃってもいいですが、どうしますか?

@k-taro56
Copy link
Contributor Author

ごめんなさい、見逃してました。マージしてもいいかと思います。

@ensan-hcl
Copy link
Owner

承知です!

@ensan-hcl ensan-hcl merged commit d1adf37 into ensan-hcl:develop May 17, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants