Skip to content

Commit

Permalink
[web] Investigate ESLint 9 (but don't switch yet) (#1964)
Browse files Browse the repository at this point in the history
Pending on facebook/react#28773

Note - once we go eslint 9, we won't need the
`--report-unused-disable-directives` in our eslint invocation:

https://eslint.org/docs/latest/use/configure/configuration-files#reporting-unused-disable-directives
  • Loading branch information
mnvr authored Jun 2, 2024
2 parents 55ee9a5 + bf2a97f commit a6b8bfc
Show file tree
Hide file tree
Showing 7 changed files with 11 additions and 13 deletions.
2 changes: 1 addition & 1 deletion web/apps/accounts/.eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,5 @@ module.exports = {
tsconfigRootDir: __dirname,
project: "./tsconfig.json",
},
ignorePatterns: [".eslintrc.js", "out"],
ignorePatterns: [".eslintrc.js", "out", "next.config.js"],
};
2 changes: 1 addition & 1 deletion web/apps/cast/.eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,5 @@ module.exports = {
tsconfigRootDir: __dirname,
project: "./tsconfig.json",
},
ignorePatterns: [".eslintrc.js", "out"],
ignorePatterns: [".eslintrc.js", "out", "next.config.js"],
};
8 changes: 7 additions & 1 deletion web/apps/photos/.eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,11 @@ module.exports = {
tsconfigRootDir: __dirname,
project: "./tsconfig.json",
},
ignorePatterns: [".eslintrc.js", "out", "thirdparty", "public"],
ignorePatterns: [
".eslintrc.js",
"out",
"thirdparty",
"public",
"next.config.js",
],
};
2 changes: 1 addition & 1 deletion web/packages/eslint-config/.eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@ module.exports = {
tsconfigRootDir: __dirname,
project: "./tsconfig.json",
},
ignorePatterns: [".eslintrc.js"],
ignorePatterns: [".eslintrc.js", "index.js"],
};
Empty file.
8 changes: 0 additions & 8 deletions web/packages/eslint-config/index.js
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
module.exports = {
extends: [
"next/core-web-vitals",
"eslint:recommended",
"plugin:@typescript-eslint/recommended",
"plugin:@typescript-eslint/recommended-requiring-type-checking",
"prettier",
],
parserOptions: {
tsconfigRootDir: __dirname,
Expand Down Expand Up @@ -34,12 +32,6 @@ module.exports = {
"after",
{ overrides: { "?": "before", ":": "before" } },
],
"import/no-anonymous-default-export": [
"error",
{
allowNew: true,
},
],
"@typescript-eslint/no-unsafe-member-access": "off",
"@typescript-eslint/no-unsafe-return": "off",
"@typescript-eslint/no-unsafe-assignment": "off",
Expand Down
2 changes: 1 addition & 1 deletion web/packages/shared/.eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,5 @@ module.exports = {
tsconfigRootDir: __dirname,
project: "./tsconfig.json",
},
ignorePatterns: [".eslintrc.js"],
ignorePatterns: [".eslintrc.js", "next/utils/headers.js"],
};

0 comments on commit a6b8bfc

Please sign in to comment.