Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for block shape/grid_shapes that would make empty localarrays. #444

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cowlicks
Copy link
Contributor

No description provided.

@cowlicks
Copy link
Contributor Author

Closes issue #442

@kwmsmith kwmsmith added the bug label Jun 16, 2014
@kwmsmith kwmsmith added this to the 0.4 milestone Jun 16, 2014
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.17%) when pulling 0f36738 on cowlicks:some-weird-shapes into 4405136 on enthought:master.

@@ -139,6 +139,9 @@ def make_grid_shape(shape, dist, comm_size):
# Trivial case: all processes used for the one distributed dimension.
if comm_size >= shape[distdims[0]]:
dist_grid_shape = (shape[distdims[0]],)
elif (('b' == shape[distdims[0]]) and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this issue show up for multi-dimensional block-distributed arrays for certain sizes? The test here needs to be more general to cover the multi-dimensional cases. If it can be refactored so it handles things on a per-dimension basis, that would be ideal.

For example, say we have a 16 engine cluster running. Currently, we get a lot of empty localarrays with a 6 x 9 block-distributed array:

In [5]: d = Distribution.from_shape(c, (6, 9), ('b', 'b'))

In [6]: d.localshapes()
Out[7]:
[(2, 3),
 (2, 3),
 (2, 3),
 (2, 0),
 (2, 3),
 (2, 3),
 (2, 3),
 (2, 0),
 (2, 3),
 (2, 3),
 (2, 3),
 (2, 0),
 (0, 3),
 (0, 3),
 (0, 3),
 (0, 0)]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this needs to be done on a per dimension basis.

@kwmsmith
Copy link
Contributor

@cowlicks what's the latest on this one?

@cowlicks
Copy link
Contributor Author

My solution here is pretty flawed. I need to incorporate a fix into the "main case" branch in make_grid_shape. So it accounts for all dimensions. I'm still figuring out how the factoring stuff in there works.

@kwmsmith kwmsmith modified the milestones: 0.5, 0.4 Jul 7, 2014
@bgrant bgrant modified the milestones: 0.5, 0.6 Aug 12, 2014
@bgrant
Copy link
Contributor

bgrant commented Oct 16, 2015

Postponing to 0.7.

@bgrant bgrant modified the milestones: 0.7, 0.6 Oct 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants