Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Enforce underscore for click command #991

Merged
merged 1 commit into from
Jul 14, 2020
Merged

FIX: Enforce underscore for click command #991

merged 1 commit into from
Jul 14, 2020

Conversation

ku-ya
Copy link
Contributor

@ku-ya ku-ya commented Jul 11, 2020

Applying a quick fix for Command names with underscores must be invoked with dashes instead when upgrading from 6.7 to 7.0

This will make the documentation command consistent: python etstools.py test_all

@ku-ya ku-ya requested a review from corranwebster July 11, 2020 16:33
corranwebster
corranwebster approved these changes Jul 12, 2020
View reviewed changes
Copy link
Contributor

@corranwebster corranwebster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good.

Do we need to change things elsewhere, such as in docstrings or README files to account for underscore-vs-hyphen

@rahulporuri
Copy link
Contributor

Do we need to change things elsewhere, such as in docstrings or README files to account for underscore-vs-hyphen

there are references to test_clean and test_all in the module docstring.

@rahulporuri
Copy link
Contributor

Ahh. I misunderstood this PR. This PR doesn't force users to only use - commands. This PR ensures that users can continue using both _ and - commands i.e. on master test_clean won't work but test-clean does. On this PR, test_clean and test-clean both work as expected.

rahulporuri
rahulporuri approved these changes Jul 14, 2020
View reviewed changes
Copy link
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rahulporuri rahulporuri mentioned this pull request Jul 14, 2020
Merged
@ku-ya ku-ya merged commit 0a4a6f4 into master Jul 14, 2020
@ku-ya ku-ya deleted the fix/click-enforce-underscore branch July 14, 2020 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahulporuri rahulporuri rahulporuri approved these changes

@corranwebster corranwebster corranwebster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ku-ya @rahulporuri @corranwebster