Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] transfer #124

Closed
Tracked by #120
mixmix opened this issue Jun 18, 2024 · 1 comment · Fixed by #140
Closed
Tracked by #120

[test] transfer #124

mixmix opened this issue Jun 18, 2024 · 1 comment · Fixed by #140
Assignees
@rh0delta

Comments

@mixmix
Copy link
Contributor

mixmix commented Jun 18, 2024 •
edited
Loading

transfer

transfer(entropy, { from: address, to: address, amount: number })
=> success (true)
=> fail (error)
@mixmix mixmix mentioned this issue Jun 18, 2024
Closed
9 tasks
@frankiebee frankiebee changed the title transfer [unit-test] transfer Jun 24, 2024
@frankiebee frankiebee changed the title [unit-test] transfer [test] transfer Jun 24, 2024
@rh0delta rh0delta self-assigned this Jun 25, 2024
rh0delta added a commit that referenced this issue Jun 26, 2024
@rh0delta
[NayNay] Transfer updates + unit testing
9946f43 
closes #124
@rh0delta rh0delta mentioned this issue Jun 26, 2024
Merged
@mixmix
Copy link
Contributor Author

mixmix commented Jun 27, 2024

@rh0delta heads up I just about picked this up cos it was in "Up Next". Luckily I saw the assignee and checked the branches you'd thankfully pushed.

Image

Let's try to move Issues on the board OR keep being paranoid OR add more automation. I'm not mad this is just me watching our system and noticing I almost wasted time with duplicate work.

@rh0delta rh0delta linked a pull request Jun 27, 2024 that will close this issue
[NayNay] Transfer updates + unit testing #140
Merged
mixmix added a commit that referenced this issue Jul 3, 2024
@rh0delta @mixmix
[NayNay] Transfer updates + unit testing (#140)
a9b4b0b 
* [NayNay] Transfer updates + unit testing

closes #124

* updated transfer pure function and added tests

* Update transfer.test.ts

Co-authored-by: mix irving <mix@protozoa.nz>

* updated based on PR suggestions

* updated progress bar use to be more universal for the cli; based on pr suggestion

* updating comment

---------

Co-authored-by: Nayyir Jutha <nayyir@entropy.xyz>
Co-authored-by: mixmix <mix@protozoa.nz>
@rh0delta rh0delta closed this as completed Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rh0delta rh0delta

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[NayNay] Transfer updates + unit testing entropyxyz/cli
2 participants
@mixmix @rh0delta