[NayNay] Debug Log #147
Merged
[NayNay] Debug Log #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rh0delta
commented
Jul 2, 2024
rh0delta
commented
- install and integrated winston logging library into cli
- allowing us to be able to log any and everything to the respective files saved in the ~/path/to/syslogs/entropy-cryptography/entropy-cli.*.log
- included example use of new logger in the tui flow for balance
- install and integrated winston logging library into cli - allowing us to be able to log any and everything to the respective files saved in the ~/path/to/syslogs/entropy-cryptography/entropy-cli.*.log - included example use of new logger in the tui flow for balance
mixmix
reviewed
Jul 3, 2024
mixmix
reviewed
Jul 3, 2024
mixmix
reviewed
Jul 3, 2024
mixmix
reviewed
Jul 3, 2024
mixmix
reviewed
Jul 3, 2024
mixmix
reviewed
Jul 3, 2024
mixmix
reviewed
Jul 3, 2024
Co-authored-by: mix irving <mix@protozoa.nz>
Co-authored-by: mix irving <mix@protozoa.nz>
|
I smoke tested this and found lots of noise in the logs. I made a lil PR to try and chill them out and this help but that issue will also need fixing |
mixmix
previously requested changes
Jul 3, 2024
There was a problem hiding this comment.
couple 🔥 I'd like to see responded to / addressed
There are some other things which need addressing too:
- installing this everywhere to replace our print/ debug
- figuring out a nice consistent pattern for that for CLI / TUI modes
This is looking great though, I think it's gonna be a massive help
…ughout cli to use new logger; added masking to the payload logged to obfuscate secret information
frankiebee
approved these changes
Jul 9, 2024
rh0delta
dismissed
mixmix’s stale review
approved by frankie, all comments addressed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.