Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chill the logs out! #161

Merged
merged 6 commits into from
Jul 16, 2024
Merged

chill the logs out! #161

merged 6 commits into from
Jul 16, 2024

Conversation

mixmix
Copy link
Contributor

@mixmix mixmix commented Jul 3, 2024

This PR was made to try and fix the logging noise made by Uint8Arrays, but there is still problem upstream:

#160

rh0delta and others added 3 commits July 2, 2024 17:30
- install and integrated winston logging library into cli
- allowing us to be able to log any and everything to the respective files saved in the ~/path/to/syslogs/entropy-cryptography/entropy-cli.*.log
- included example use of new logger in the tui flow for balance
src/common/logger.ts Outdated Show resolved Hide resolved
src/common/utils.ts Outdated Show resolved Hide resolved
Co-authored-by: Nayyir Jutha <nayyir.jutha@gmail.com>
@rh0delta
Copy link
Contributor

rh0delta commented Jul 3, 2024

@mixmix you think we need a migration to update how we are setting the config through config.set? I believe if we update stringification there we should be able to get away from needing a migration because of how we are subscribing to updates. The data gets refreshed everytime, so it should get fixed once the method is updated with your new replacer method

@mixmix
Copy link
Contributor Author

mixmix commented Jul 4, 2024

I'm worried it is desrializing wrong. Frankie said it's likely only working cos we use the seed not the secretKey.
i've got it half written today in a branch (pr later)

Base automatically changed from naynay/debug-log to dev July 9, 2024 18:02
@mixmix
Copy link
Contributor Author

mixmix commented Jul 16, 2024

well that PR collapsed down nice!
ready for another review @rh0delta / smoke test

@mixmix mixmix merged commit 8dabd11 into dev Jul 16, 2024
1 check passed
@mixmix mixmix deleted the naynay/debug-log_REMIX branch July 16, 2024 04:56
@mixmix
Copy link
Contributor Author

mixmix commented Jul 16, 2024

@rh0delta GO TO BED
also thanks for the reviews. AND if you review and approve feel free to merge! (unless there is some "wait till X is in" note)

❤️ 💤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants