Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixmix/fix deserialize #190

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Mixmix/fix deserialize #190

merged 1 commit into from
Jul 18, 2024

Conversation

mixmix
Copy link
Contributor

@mixmix mixmix commented Jul 18, 2024

saw some aggressive deserialization of EVERY thing that was valid base64.
was breaking CLI functions badly

Related Issue(s)

  • Resolves NOPE, straight to PR 👹

Proposed Changes

Rather than write a "block list" of keys whose value to not convert from base64 => UInt8Array (which would be brittle) I:

  • Changed serialization to use a PREFIX so that it is 100% clear that something came from UInt8Array
  • Updated tests

Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed

Checklist

  • I have performed a self-review of my code.
  • I have added tests.
  • I have commented my code.
  • I have included a CHANGELOG.md entry.
  • I have updated documentation in github.com:entropyxyz/entropy-docs, where necessary.

@mixmix mixmix requested a review from rh0delta July 18, 2024 02:20
@mixmix mixmix changed the base branch from main to dev July 18, 2024 02:20
@mixmix
Copy link
Contributor Author

mixmix commented Jul 18, 2024

⚠️ this will require you to blow away your config file
The migrations assume they will run for a person who's been running main. I'm not writing a migration to fix a broken dev state soz

@mixmix mixmix merged commit 166a1a2 into dev Jul 18, 2024
1 check passed
@mixmix mixmix deleted the mixmix/fix-deserialize branch July 18, 2024 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants