[NayNay] Fixing register tests #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- mistakingly tested the wrong register method - fixed it
|
@mixmix I have updated the test to use the correct, and newly created, register method. This should satisfy the requirement to test the custom program functionality |
rh0delta
commented
Jul 22, 2024
Comment on lines
+32
to
35
| 'register - using custom params', | ||
| register(entropy, { | ||
| programModAddress: entropy.keyring.accounts.registration.address, | ||
| programData: [{ program_pointer: pointer, program_config: '0x' }], |
There was a problem hiding this comment.
this is the fix to review, the rest is cleanup
mixmix
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s)
Proposed Changes
Testing
Screenshots (if applicable)
Additional Context
Checklist
CHANGELOG.mdentry.github.com:entropyxyz/entropy-docs, where necessary.