[NayNay] File Restructure: Accounts Restructure #215

rh0delta · 2024-08-05T17:25:29Z

Related Issue(s)

Resolves accounts restructure #210

Proposed Changes

refactoring file structure + flow of accounts in cli/tui

Testing

Unit tests added/updated
Integration tests added/updated
Manual testing performed

Screenshots (if applicable)

Additional Context

Checklist

I have performed a self-review of my code.
I have added tests.
I have commented my code.
I have included a CHANGELOG.md entry.
I have updated documentation in github.com:entropyxyz/entropy-docs, where necessary.

- refactoring file structure + flow of accounts in cli/tui

…structure; still need to update tests

mixmix

Looking good. Scope creep means you get some annoying questions sorry 😢
I have not got to the end of reviewing this. Keen to pause here and review again once other things have been resolved to catch any final minor gotchas

src/cli.ts

src/common/utils.ts

src/cli.ts

src/accounts/command.ts

src/accounts/utils.ts

src/account/command.ts

src/account/main.ts

tests/manage-accounts.test.ts

…nto naynay/accounts-restructure

tests/account.test.ts

…mands

tests/transfer.test.ts

src/balance/command.ts

Co-authored-by: mix irving <mix@protozoa.nz>

src/config/index.ts

mixmix

MORE REVIEWS

tests/account.test.ts

tests/register.test.ts

src/account/main.ts

src/account/command.ts

src/common/utils.ts

src/account/command.ts

src/cli.ts

…opyxyz/cli into naynay/accounts-restructure

src/account/main.ts

src/cli.ts

mixmix · 2024-09-19T00:34:22Z

✔️ MERGE!!!!

rh0delta added 7 commits August 5, 2024 13:23

[NayNay] File Restructure: Accounts Restructure

4e0532a

- refactoring file structure + flow of accounts in cli/tui

Merge branch 'naynay/file-restructure' into naynay/accounts-restructure

af58213

updated new account, list account and selected account with new file …

e9411ce

…structure; still need to update tests

finished updated manage accoutns stuff, updated tests too

6d46831

updated register flow and moved methods to accounts namespace

8063677

updated register tests

118c5a7

cleanup from smoke test

6dfd8b2

rh0delta marked this pull request as ready for review August 7, 2024 14:44

rh0delta linked an issue Aug 7, 2024 that may be closed by this pull request

accounts restructure #210

Closed

rh0delta added 2 commits August 7, 2024 13:39

updated changelog

9d22f6a

Merge branch 'naynay/file-restructure' into naynay/accounts-restructure

b59a656

mixmix requested changes Aug 22, 2024

View reviewed changes

mixmix reviewed Aug 22, 2024

View reviewed changes

src/accounts/command.ts Outdated Show resolved Hide resolved

mixmix reviewed Aug 22, 2024

View reviewed changes

src/accounts/command.ts Outdated Show resolved Hide resolved

mixmix reviewed Aug 22, 2024

View reviewed changes

src/accounts/utils.ts Outdated Show resolved Hide resolved

start refactor

1b7aa6f

mixmix self-assigned this Aug 28, 2024

mixmix and others added 4 commits August 28, 2024 17:11

WIP: part way refactored account stuff

ec0609f

cleaning up the cleanup for accounts restructure;

3aa419b

forgot something

9cc1c67

updated accounts restructure, continuing from mixs changes

249ca3e

rh0delta commented Aug 28, 2024

View reviewed changes

src/account/command.ts Outdated Show resolved Hide resolved

rh0delta commented Aug 28, 2024

View reviewed changes

src/account/main.ts Outdated Show resolved Hide resolved

Update main.ts

6cd2e9f

rh0delta commented Aug 28, 2024

View reviewed changes

tests/manage-accounts.test.ts Outdated Show resolved Hide resolved

rh0delta and others added 5 commits August 28, 2024 19:13

Update manage-accounts.test.ts

b5af231

Merge branch 'naynay/file-restructure' of github.com:entropyxyz/cli i…

036936b

…nto naynay/accounts-restructure

fixups

9cb1b81

WIP

dbbb777

fixups

378fffa

rh0delta commented Aug 29, 2024

View reviewed changes

tests/account.test.ts Outdated Show resolved Hide resolved

mixmix and others added 2 commits August 29, 2024 17:05

get working for fresh install. see WIP

50ab1e1

fixed fresh install and using tui, might have fixed cli not sure

b013ce3

rh0delta force-pushed the naynay/accounts-restructure branch from 42a0d67 to b013ce3 Compare August 30, 2024 17:15

updated initialization of entropy and formt of how we instantiate com…

2272689

…mands

rh0delta requested review from frankiebee and mixmix September 13, 2024 19:08

rh0delta added 3 commits September 16, 2024 14:15

Merge branch 'naynay/file-restructure' into naynay/accounts-restructure

35eecee

skipping faucet test for now, shenanigans occurring

6951167

fixed faucet test

96d273c

frankiebee reviewed Sep 16, 2024

View reviewed changes

tests/transfer.test.ts Show resolved Hide resolved

updated tests;

930d149

mixmix assigned rh0delta and unassigned mixmix Sep 16, 2024

mixmix reviewed Sep 17, 2024

View reviewed changes

src/balance/command.ts Outdated Show resolved Hide resolved

Update command.ts

6d0ea12

Co-authored-by: mix irving <mix@protozoa.nz>

mixmix reviewed Sep 17, 2024

View reviewed changes

src/config/index.ts Outdated Show resolved Hide resolved

mixmix requested changes Sep 17, 2024

View reviewed changes

rh0delta added 2 commits September 17, 2024 12:48

pr review updates

c941e17

Merge branch 'naynay/accounts-restructure' of https://github.com/entr…

40774cc

…opyxyz/cli into naynay/accounts-restructure

rh0delta requested a review from mixmix September 17, 2024 20:08

mixmix reviewed Sep 17, 2024

View reviewed changes

src/account/main.ts Show resolved Hide resolved

mixmix reviewed Sep 17, 2024

View reviewed changes

src/cli.ts Outdated Show resolved Hide resolved

Update src/cli.ts

3e091f9

mixmix reviewed Sep 17, 2024

View reviewed changes

src/cli.ts Outdated Show resolved Hide resolved

account-restructure tweaks (#226)

183e200

mixmix merged commit 0cfb8f8 into naynay/file-restructure Sep 19, 2024
2 checks passed

mixmix deleted the naynay/accounts-restructure branch September 19, 2024 00:34

github-actions bot locked and limited conversation to collaborators Sep 19, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NayNay] File Restructure: Accounts Restructure #215

[NayNay] File Restructure: Accounts Restructure #215

rh0delta commented Aug 5, 2024 •

edited

Loading

mixmix left a comment

mixmix left a comment

mixmix commented Sep 19, 2024

[NayNay] File Restructure: Accounts Restructure #215

[NayNay] File Restructure: Accounts Restructure #215

Conversation

rh0delta commented Aug 5, 2024 • edited Loading

Related Issue(s)

Proposed Changes

Testing

Screenshots (if applicable)

Additional Context

Checklist

mixmix left a comment

Choose a reason for hiding this comment

mixmix left a comment

Choose a reason for hiding this comment

MORE REVIEWS

mixmix commented Sep 19, 2024

✔️ MERGE!!!!

rh0delta commented Aug 5, 2024 •

edited

Loading