refactor entropy register so CLI/TUI are similar #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mixmix
commented
Sep 26, 2024
| const entropy: Entropy = await loadEntropy(accountToRegister.address, endpoint) | ||
| const accountService = new EntropyAccount(entropy, endpoint) | ||
| const updatedAccount = await accountService.registerAccount(accountToRegister) | ||
| // NOTE: loadEntropy throws if it can't find opts.account |
There was a problem hiding this comment.
Suggested change
| // NOTE: loadEntropy throws if it can't find opts.account | |
| // NOTE: loadEntropy throws if it can't find opts.account | |
| // This is important because we don't want to register if we don't have a place to persist later |
mixmix
commented
Sep 26, 2024
| @@ -75,28 +76,6 @@ export class EntropyAccount extends EntropyBase { | |||
| }) | |||
| } | |||
|
|
|||
| // WATCH: should this be extracted to interaction.ts? | |||
| async registerAccount (account: EntropyAccountConfig, registerParams?: AccountRegisterParams): Promise<EntropyAccountConfig> { | |||
There was a problem hiding this comment.
All this function is is registerAndPushKeysIntoAccount
I have pulled this out into the verbosely named util which
- pushes into account
- persists config
There was a problem hiding this comment.
it's also the lgger correct?
mixmix
commented
Sep 26, 2024
| export async function addVerifyingKeyToAccountAndSelect (verifyingKey: string, accountNameOrAddress: string) { | ||
| const storedConfig = await config.get() | ||
| const account = findAccountByAddressOrName(storedConfig.accounts, accountNameOrAddress) | ||
| if (!account) throw Error(`Unable to persist verifyingKey "${verifyingKey}" to unknown account "${accountNameOrAddress}"`) |
There was a problem hiding this comment.
This is very unlikely because we have earlier checked the account exists...but we put a nice message out anyway 🤷
Alternative.. make a function with an uglier signature (storeConfig, verifyingKey, account) ? 😢 this could still fail if account is not within storedConfig.accounts tho ...
mixmix
commented
Sep 26, 2024
Comment on lines
+34
to
+37
| await config.set({ | ||
| ...storedConfig, | ||
| selectedAccount: account.address | ||
| }) |
There was a problem hiding this comment.
Check my working.
We don't need to any of the fancy slicing or inserting accounts here because:
- on line 28 : we grab the ref for target
accountinstoredConfig.accounts - on line 31 : we push a key into that account's data (mutating it)
- on line 35 : we say "persist that mutated storedConfig"
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During QA discussion, notice that entropy register was coded the same in CLI + TUI.
This PR:
maindoes to only be registering on-chainutilcommandandinteractionto use the same 2 functionscommandaction