Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NayNay] Husky issue on fresh install #255

Merged
merged 8 commits into from
Nov 6, 2024
Merged

[NayNay] Husky issue on fresh install #255

merged 8 commits into from
Nov 6, 2024
+0 −1

Conversation

rh0delta
Copy link
Contributor

@rh0delta rh0delta commented Oct 15, 2024 •
edited
Loading

Related Issue(s)

Proposed Changes

  • found the issue to be an inccorect node version being used, updated package json to force version of node that is currently compatible with the cli

Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed

Screenshots (if applicable)

Additional Context

Checklist

  • I have performed a self-review of my code.
  • I have added tests.
  • I have commented my code.
  • I have included a CHANGELOG.md entry.
  • I have updated documentation in github.com:entropyxyz/entropy-docs, where necessary.

@mixmix
Copy link
Contributor

mixmix commented Oct 28, 2024

Requires use to push out an RC to see about the dep issue.

This should go in RC2 for testing
Is gonna require a lot of trial and error... may be something about post-install script...
Frankie was able to reproduce this, can help publish RCs

@rh0delta rh0delta marked this pull request as ready for review October 31, 2024 21:49
@mixmix mixmix marked this pull request as draft November 4, 2024 23:32
@rh0delta rh0delta marked this pull request as ready for review November 5, 2024 17:53
@rh0delta rh0delta linked an issue Nov 6, 2024 that may be closed by this pull request
Getting NPM install errors when trying to install the CLI. #251
Closed
@mixmix mixmix merged commit f3c32d5 into dev Nov 6, 2024
2 checks passed
@mixmix mixmix deleted the naynay/husky-issue branch November 6, 2024 01:56
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mixmix mixmix mixmix approved these changes

@frankiebee frankiebee Awaiting requested review from frankiebee

Assignees
No one assigned
Labels
release-requirement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Getting NPM install errors when trying to install the CLI.
2 participants
@rh0delta @mixmix