Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NayNay] Signing error messaging #260

Merged
merged 3 commits into from
Oct 22, 2024
Merged

[NayNay] Signing error messaging #260

merged 3 commits into from
Oct 22, 2024

Conversation

rh0delta
Copy link
Contributor

Related Issue(s)

Proposed Changes

  • updated signing error handling to return human readbale message when user tries to sign without registering first

Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed

Screenshots (if applicable)

Additional Context

Checklist

  • I have performed a self-review of my code.
  • I have added tests.
  • I have commented my code.
  • I have included a CHANGELOG.md entry.
  • I have updated documentation in github.com:entropyxyz/entropy-docs, where necessary.

- updated signing error handling to return human readbale message when user tries to sign without registering first
@rh0delta rh0delta linked an issue Oct 18, 2024 that may be closed by this pull request
Copy link
Contributor

@mixmix mixmix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GORGEOUS

@mixmix mixmix merged commit cab7dec into dev Oct 22, 2024
2 checks passed
@mixmix mixmix deleted the naynay/signing-issue222 branch October 22, 2024 01:49
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Signing fails if user doesn't have a verifying key set.
2 participants