[NayNay] New SDK RC integration #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- updated CLI with new sdk rc, and made changes to reflect the changes from core/sdk - updated network type defualt to four-nodes - added jump-start network to the initialization of entropy for both cli and tui - updated all tests to reflect changes
rh0delta
commented
Oct 22, 2024
mixmix
reviewed
Oct 22, 2024
mixmix
reviewed
Oct 22, 2024
tests/account.test.ts
Outdated
Comment on lines
88
to
98
| // Naynay entropy instance required here as @JesseAbram brought to attn that running jumpstart using the charlie seed will result in errors. | ||
| // the error found here was: RpcError: 1014: Priority is too low: (4471 vs 4471): The transaction has too low priority to replace another transaction already in the pool. | ||
| // which indicated a potential nonce issue, where the solution would be to manually wait for ~50 blocks to make any subsequent calls to the network. However, | ||
| // using naynay instance (fresh seed) jump start and the subsequent calls to the network (i.e register), the flow worked without issues. | ||
| const { entropy: naynay } = await setupTest(t, { networkType }) | ||
|
|
||
| const accountService = new EntropyAccount(naynay, endpoint) | ||
| const transferService = new EntropyTransfer(entropy, endpoint) | ||
|
|
||
| // use of charlie seed is solely to transfer funds to the naynay (fresh seed) instance. these funds will be used for the jumpstart and register call | ||
| await run('transferring funds', transferService.transfer(naynay.keyring.accounts.registration.address, "1000")) |
There was a problem hiding this comment.
I think the setup should be extracted (set up of a funded account).
mixmix
reviewed
Oct 23, 2024
mixmix
reviewed
Oct 23, 2024
mixmix
reviewed
Oct 23, 2024
* exract "fundAccount" from tests * extraaact * tidy * Update tests/faucet.test.ts Co-authored-by: Nayyir Jutha <nayyir.jutha@gmail.com> * Update tests/faucet.test.ts Co-authored-by: Nayyir Jutha <nayyir.jutha@gmail.com> * fixed test --------- Co-authored-by: Nayyir Jutha <nayyir.jutha@gmail.com>
mixmix
reviewed
Oct 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s)
Proposed Changes
Testing
Screenshots (if applicable)
Additional Context
Checklist
CHANGELOG.mdentry.github.com:entropyxyz/entropy-docs, where necessary.