fix opt.tuiEndpoint references, and entropy reloading #281
+422
−163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rh0delta
approved these changes
Nov 6, 2024
mixmix
commented
Nov 6, 2024
Comment on lines
-99
to
-104
| const currentAccount = entropy?.keyring?.accounts?.registration?.address | ||
| if (currentAccount && currentAccount !== storedConfig.selectedAccount) { | ||
| const currentAccount = findAccountByAddressOrName( | ||
| storedConfig.accounts, | ||
| entropy?.keyring?.accounts?.registration?.address | ||
| ) | ||
| if (currentAccount && currentAccount.name !== storedConfig.selectedAccount) { | ||
| await entropy.close() | ||
| entropy = await loadEntropy(storedConfig.selectedAccount, options.tuiEndpoint); | ||
| entropy = await loadEntropy(storedConfig.selectedAccount, options.endpoint); | ||
| } | ||
|
|
There was a problem hiding this comment.
This was the major tui slowdown. selectedAccount is stored as account.name now, not account.address, so this was if (true) meaning loadEntropy was always being called another time
This doubled tui startup from 2s => 4s, which felt stink!
|
Hmm, second time I've see that in CI: |
|
Have added a commit which blocks the writing of bad config (some) |
mixmix
commented
Nov 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.