Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI base #91

Merged
merged 12 commits into from
Jun 12, 2024
Merged

CLI base #91

merged 12 commits into from
Jun 12, 2024

Conversation

mixmix
Copy link
Contributor

@mixmix mixmix commented Jun 11, 2024

This PR adds:

  • compling (ts => js)
    • I have copied the sdk setup
    • I wasted time trying something new. we should come back and update this when we figure out a beautiful TS pattern
  • commander, which captures CLI input and will allow us to add programmatic functions nicely
  • deletes some unused questions.ts file

mixmix
mixmix commented Jun 11, 2024
View reviewed changes
package.json Show resolved Hide resolved
@mixmix mixmix mentioned this pull request Jun 11, 2024
Merged
rh0delta
rh0delta approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@rh0delta rh0delta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me, @frankiebee do you want to give it a once over too?

frankiebee
frankiebee requested changes Jun 11, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
src/common/ascii.ts Outdated Show resolved Hide resolved
tsconfig.json Outdated Show resolved Hide resolved
tsconfig.json Outdated Show resolved Hide resolved
tsconfig.json Outdated Show resolved Hide resolved
mixmix and others added 5 commits June 12, 2024 10:54
@mixmix @frankiebee
Update tsconfig.json
cdf0604 
Co-authored-by: Frankie <frankie.diamond@gmail.com>
@mixmix @frankiebee
Update tsconfig.json
961f903 
Co-authored-by: Frankie <frankie.diamond@gmail.com>
@mixmix @frankiebee
Update tsconfig.json
0c502ac 
Co-authored-by: Frankie <frankie.diamond@gmail.com>
@mixmix
fixups
8727740
@mixmix
Merge branch 'main' of github.com:entropyxyz/cli into mixmix/CLI_base
740cd34
@mixmix mixmix requested a review from frankiebee June 12, 2024 02:34
@mixmix
Copy link
Contributor Author

mixmix commented Jun 12, 2024

@frankiebee this is ready for sign off. This Changes Requested 🔒 is both good and annoying 👹

rh0delta
rh0delta approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@rh0delta rh0delta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor change in readme, otherwise it looks good

README.md Outdated Show resolved Hide resolved
@rh0delta rh0delta changed the base branch from main to dev June 12, 2024 20:46
mixmix and others added 2 commits June 13, 2024 09:29
@mixmix mixmix merged commit b27a9e5 into dev Jun 12, 2024
@mixmix mixmix deleted the mixmix/CLI_base branch June 12, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rh0delta rh0delta rh0delta approved these changes

@frankiebee frankiebee Awaiting requested review from frankiebee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mixmix @frankiebee @rh0delta