Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assume tag is lost if ADPU command does not respond with an ADPU response #26

Merged
merged 4 commits into from
Sep 23, 2023
Merged

Assume tag is lost if ADPU command does not respond with an ADPU response #26

merged 4 commits into from
Sep 23, 2023

Conversation

skjolber
Copy link
Contributor

@skjolber skjolber commented Sep 14, 2023 •
edited
Loading

The current "tag lost" only happens when a new tag is discovered.

  • if no ADPU response is returned by the reader, assume tag lost
  • emit tag lost broadcasts
  • set extra flag which make further communications impossible (which should already be blocked via removal from the TagProxy)

@skjolber skjolber requested a review from Hekkii September 14, 2023 10:40
@Hekkii
Copy link
Contributor

Hekkii commented Sep 15, 2023

Skal teste med Minova ila dagen.

@Hekkii
Update MinovaCommand always throws exception
a709b52 
Every response is prepended with reader id
Hekkii
Hekkii approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@Hekkii Hekkii left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ikke noen duplicates under testing, men det er vanskelig å bekrefte skikkelig. Skjer nokså sjeldent med ACR1252U, og har ikke opplevd det med Minova (fordi jeg i hovedsak tester med ACR-leseren).

@skjolber skjolber merged commit f9b0f40 into master Sep 23, 2023
1 check passed
@skjolber skjolber deleted the moreExplicitRemoveTagForMinova branch September 23, 2023 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hekkii Hekkii Hekkii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skjolber @Hekkii