Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android cert verifier: first import from chromium/net #2222

Merged

Conversation

StefanoDuo
Copy link
Contributor

Initial import of the chromium/net classes that act as a bridge between
the C++ layer and the Android framework calls.
This code calls into framework code, so we will need to setup emulator
tests. For the time being these are being succeffully compiled within
//library/java/org/chromium/net:net.

Signed-off-by: Stefano Duo stefanoduo@google.com

For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md

Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]

Initial import of the chromium/net classes that act as a bridge between
the C++ layer and the Android framework calls.
This code calls into framework code, so we will need to setup emulator
tests. For the time being these are being succeffully compiled within
//library/java/org/chromium/net:net.

Signed-off-by: Stefano Duo <stefanoduo@google.com>
Signed-off-by: Stefano Duo <stefanoduo@google.com>
Signed-off-by: Stefano Duo <stefanoduo@google.com>
Signed-off-by: Stefano Duo <stefanoduo@google.com>
@StefanoDuo StefanoDuo marked this pull request as ready for review April 28, 2022 13:27
@StefanoDuo
Copy link
Contributor Author

@carloseltuerto I've removed the headers and marked classes as final.

@carloseltuerto carloseltuerto self-requested a review April 28, 2022 13:31
Copy link
Contributor

@carloseltuerto carloseltuerto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Stefano.

@carloseltuerto carloseltuerto merged commit 30e9090 into envoyproxy:main Apr 28, 2022
@StefanoDuo
Copy link
Contributor Author

#1575

jpsim added a commit that referenced this pull request May 2, 2022
* origin/main:
  Bump rules_apple to 0.34.2 (#2236)
  Bump Lyft Support Rotation (#2232)
  ci: add support for `/retest` command (#2219)
  format: add SwiftLint to check-format script (#2230)
  use 64 bit emulators for test (#2228)
  envoy: update to `d0befbb` & add `h2ExtendKeepaliveTimeout` (#2229)
  Add Ryan Hamilton to OWNERS.md (#2224)
  Android cert verifier: first import from chromium/net (#2222)

Signed-off-by: JP Simard <jp@jpsim.com>
jpsim added a commit that referenced this pull request May 3, 2022
…rtion

* origin/main: (57 commits)
  network: add enableDrainPostDnsRefresh to iOS (#2242)
  envoy: update to em-cherry (#2241)
  network: support draining connections after triggered DNS refresh (#2225)
  Bump rules_apple to 0.34.2 (#2236)
  Bump Lyft Support Rotation (#2232)
  ci: add support for `/retest` command (#2219)
  format: add SwiftLint to check-format script (#2230)
  use 64 bit emulators for test (#2228)
  envoy: update to `d0befbb` & add `h2ExtendKeepaliveTimeout` (#2229)
  Add Ryan Hamilton to OWNERS.md (#2224)
  Android cert verifier: first import from chromium/net (#2222)
  Cleanup: remove the unused stats sink metrics_service (#2220)
  bazel: move back to symbol mapping table files (#2218)
  Add new version history section (#2209)
  build: simplify jnilib copy (#2214)
  ci: Update macOS version to macOS 12 (#2208)
  Update releasing.rst (#2200)
  support: Post Lyft support rotation changes to Slack (#2207)
  Don't run bump_support_rotation GitHub Action on forks (#2204)
  Release 0.4.6 (#2201)
  ...

Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants