Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kotlin: fix flaky grpc test #2316

Merged
merged 1 commit into from
May 25, 2022
Merged

kotlin: fix flaky grpc test #2316

merged 1 commit into from
May 25, 2022

Conversation

jpsim
Copy link
Contributor

@jpsim jpsim commented May 25, 2022

@jpsim jpsim marked this pull request as ready for review May 25, 2022 14:29
@jpsim jpsim requested a review from alyssawilk May 25, 2022 14:30
RyanTheOptimist
RyanTheOptimist approved these changes May 25, 2022
View reviewed changes
Copy link
Contributor

@RyanTheOptimist RyanTheOptimist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for such a quick fix!

@RyanTheOptimist RyanTheOptimist merged commit a21da13 into main May 25, 2022
@RyanTheOptimist RyanTheOptimist deleted the kotlin-fix-flaky-grpc-test branch May 25, 2022 14:51
jpsim added a commit that referenced this pull request May 26, 2022
@jpsim
Merge remote-tracking branch 'origin/main' into jp-real-engine-handles
24cb769 
* origin/main: (32 commits)
  Compress xcframework release asset (#2324)
  bazel: update rules_apple (#2326)
  Merge `android_dist` with `android_dist_ci` (#2323)
  kotlin: fix flaky receive error test (#2317)
  kotlin: fix flaky grpc test (#2316)
  build(deps): bump pyjwt from 2.1.0 to 2.4.0 in /.github/actions/pr_notifier (#2314)
  test: making C++ integration test more authentic (#2315)
  reverting override to override_request_timeout_by_gateway_timeout (#2296)
  Update Envoy (#2309)
  release: use `CREDENTIALS_GITHUB_RELEASE_DEPLOY_KEY`
  Use `CREDENTIALS_GITHUB_PUSH_TOKEN`
  Push to branch before tagging the release
  Cronvoy: preparation to unittest certificate verification JNI (#2251)
  Corrected typo in documentation for Android building requirements (#2313)
  instrumentation: add timers and warnings to platform callbacks (#2300)
  Bump Lyft Support Rotation (#2310)
  Revert "android: use local addresses as opposed to prefix (#2081)" (#2307)
  Fix release GitHub workflow (#2306)
  mobile: moving the c++ integration test to use default config (#2293)
  config: cleaning up deprecated configs (#2295)
  ...

Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanTheOptimist RyanTheOptimist RyanTheOptimist approved these changes

@alyssawilk alyssawilk Awaiting requested review from alyssawilk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

//test/kotlin/integration:grpc_receive_error_test flake
2 participants
@jpsim @RyanTheOptimist