Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: add arm64 debug run configuration #2424

Merged
merged 2 commits into from
Jul 18, 2022
Merged

tools: add arm64 debug run configuration #2424

merged 2 commits into from
Jul 18, 2022

Conversation

Augustyniak
Copy link
Contributor

@Augustyniak Augustyniak commented Jul 15, 2022 •
edited
Loading

Description: Add an arm64 run configuration for Envoy example app so that it's possible to run and debug Envoy Mobile example app on ARM machines (i.e., M1 Macbooks). Following steps from https://envoy-mobile.github.io/docs/envoy-mobile/latest/development/debugging/android_local.html#adding-envoy-mobile-project-into-android-studio it's possible to set up an Android project that makes it possible to run and debug Envoy Mobile example app (put symbolic breakpoints in Envoy code). As it is now, the configured/added run configuration supports running of x86 builds only which do not work on ARM machines.
Risk Level: None
Testing: Run new configuration locally on M1 Macbook.
Docs Changes: N/A
Release Notes: N/A

Signed-off-by: Rafal Augustyniak raugustyniak@lyft.com

@Augustyniak
add arm64 debug run configuration
36ac58d 
Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
@Augustyniak Augustyniak requested review from jpsim and goaway July 15, 2022 14:21
Augustyniak
Augustyniak commented Jul 15, 2022
View reviewed changes
...ello_world/tools/android-studio-run-configurations/run_configuration_example_debug_arm64.xml
@@ -0,0 +1,38 @@
<configuration name="Example App (Debug) [arm64]"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this configuration is basically a copy-paste of the existing x86 run configuration

jpsim
jpsim previously approved these changes Jul 18, 2022
View reviewed changes
Copy link
Contributor

@jpsim jpsim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update the docs to mention picking the architecture to match your host machine and reflect the x86 rename?

From Android Studio select the Example App x86 (Debug) configuration

@Augustyniak
update docs
684da7b 
Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
@Augustyniak
Copy link
Contributor Author

Can you also update the docs to mention picking the architecture to match your host machine and reflect the x86 rename?

From Android Studio select the Example App x86 (Debug) configuration

This part of the documentation is not up to date in general (as we removed dist/ directory in #2184) and I was planning to revamp it in one of the follow up PRs. Can start doing it in this PR too tho.

There are other things I will need to follow up on such as - While breaking on a C++ function, Android Studio should present the source file and highlight the line where the breakpoint hit with all scope information which I cannot make to work for me.

@Augustyniak
Copy link
Contributor Author

Pushed a documentation update in 684da7b

@Augustyniak Augustyniak requested a review from jpsim July 18, 2022 16:02
@Augustyniak Augustyniak enabled auto-merge (squash) July 18, 2022 16:04
@Augustyniak Augustyniak merged commit 4239fe0 into main Jul 18, 2022
@Augustyniak Augustyniak deleted the add-configuration-for-arm-run branch July 18, 2022 16:33
jpsim added a commit that referenced this pull request Jul 18, 2022
@jpsim
Merge branch 'main' into jp-xcode-13.4
4f1bdef 
* main:
  tools: fix source mapping (#2429)
  Update Envoy (#2427)
  tools: add arm64 debug run configuration (#2424)
  Revert "docs: use sphinx githubpages extension (#2418)" (#2425)
  Remove Tulsi configuration & docs (#2421)
  Fix isCleartextTrafficPermitted (#2420)
  Squelch two JNI build warnings (#2426)
  dns: allow using the `getaddrinfo`-based system DNS resolver (#2419)
  docs: use sphinx githubpages extension (#2418)
  Update Envoy (#2417)
  Remove rules_cc uses
  Bump Lyft Support Rotation (#2414)
  iOS: fix retain cycles in `EnvoyNetworkMonitor` (#2415)
  Update Envoy (#2413)
  engine: remove outdated comment about `registerFactories()` (#2412)
  api: make RequestTrailersBuilder and ResponseHeadersBuilder constructors public (#2410)

Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpsim jpsim jpsim approved these changes

@goaway goaway Awaiting requested review from goaway

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Augustyniak @jpsim