Update Envoy #2435
Merged
Update Envoy #2435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: GitHub Action <noreply@github.com>
|
Blocked on bazelbuild/rules_java#57 |
Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: JP Simard <jp@jpsim.com>
* origin/main: bazel: update rules-proto-grpc to 4.1.1 (#2437) Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
reviewed
Jul 21, 2022
bazel/envoy_mobile_repositories.bzl
Outdated
| url = "https://github.com/bazelbuild/rules_java/archive/refs/tags/5.0.0.tar.gz", | ||
| sha256 = "19462d64b1586c0d4ea0e87f9325be2514f0eb84e56dbf3245450451b3701581", | ||
| strip_prefix = "rules_java-43243982abc76390ef64be62379a1353f9011771", | ||
| # TODO(jpsim): Switch back to bazelbuild repo when https://github.com/bazelbuild/rules_java/pull/65 is merged |
There was a problem hiding this comment.
@Bencodes do you have a better idea here? Do you think it's ok to use this reverted branch for now to unblock?
Some details as to the error we're hitting in bazelbuild/rules_java#64
Closed
Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: JP Simard <jp@jpsim.com>
|
I think we should merge this to stay up to date with upstream Envoy changes. The rules_java PR this points to (bazelbuild/rules_java#65) reverts a change that shouldn't have any negative impacts for us since we don't ship a JDK with Envoy Mobile and therefore should be safe for us to pull in until bazelbuild/rules_java#64 is resolved. |
keith
approved these changes
Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated changes by create-pull-request GitHub action