bazel: update to 3.1.0 #850
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose Nino <jnino@lyft.com>
rebello95
previously approved these changes
May 14, 2020
Signed-off-by: Jose Nino <jnino@lyft.com>
|
Taking a look at what it would mean to update to 3.1.0 to avoid the linking issue with bazelisk. I understand this is sweeping the underlying problem under the rug by complying with what is installed in the CI machines, but I'd rather unblock CI and then figure out how to correctly install and link bazelisk in macos. Created envoyproxy/envoy#11210 to track in upstream |
rebello95
previously approved these changes
May 14, 2020
Signed-off-by: Alan Chiu <achiu@lyft.com>
.github/workflows/android.yml
Outdated
| @@ -89,7 +89,7 @@ jobs: | |||
| - run: ls -lh dist/ | |||
| - name: start simulator | |||
| run: ./ci/mac_start_emulator.sh | |||
| - run: bazel mobile-install --fat_apk_cpu=x86 --start_app //examples/kotlin/hello_world:hello_envoy_kt | |||
| - run: bazel mobile-install --host_force_python=PY2 --fat_apk_cpu=x86 //examples/kotlin/hello_world:hello_envoy_kt | |||
There was a problem hiding this comment.
Suggested change
| - run: bazel mobile-install --host_force_python=PY2 --fat_apk_cpu=x86 //examples/kotlin/hello_world:hello_envoy_kt | |
| - run: bazel mobile-install --host_force_python=PY2 --fat_apk_cpu=x86 //examples/kotlin/hello_world:hello_envoy_kt |
from error message: bazelbuild/bazel#7899
Note: The failure of target @bazel_tools//tools/android:incremental_install (with exit code 1) may have been caused by the fact that it is a Python 2 program that was built in the host configuration, which uses Python 3. You can change the host configuration (for the entire build) to instead use Python 2 by setting --host_force_python=PY2.
If this error started occurring in Bazel 0.27 and later, it may be because the Python toolchain now enforces that targets analyzed as PY2 and PY3 run under a Python 2 and Python 3 interpreter, respectively. See https://github.com/bazelbuild/bazel/issues/7899 for more information.```
There was a problem hiding this comment.
No, that is just a red herring they already updated to pyhon 3 in bazelbuild/bazel@d93a146#diff-947a45ac6fb178dbfb7cc530fddd6b9a
added 7 commits
May 15, 2020 10:32
Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: Jose Nino <jnino@lyft.com>
…-3.1.0 Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: Jose Nino <jnino@lyft.com>
added 12 commits
May 15, 2020 12:44
Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: Jose Nino <jnino@lyft.com>
added 8 commits
May 15, 2020 17:04
Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: Jose Nino <jnino@lyft.com>
|
closing in favor of #854 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jose Nino jnino@lyft.com