Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coverage report started failing #187

Open
mum4k opened this issue Jan 4, 2023 · 3 comments
Open

Coverage report started failing #187

mum4k opened this issue Jan 4, 2023 · 3 comments
Assignees
@mum4k
Labels
no stalebot Exempts an issue or a PR from the stalebot.

Comments

@mum4k
Copy link
Contributor

mum4k commented Jan 4, 2023

We get the following error.

==================== Test output for //src/lib:test_cmd_exec:
Unrecognized option '[run] relative_files=' in config file /usr/local/google/home/mumak/.cache/bazel/_bazel_mumak/0692d959e92750360f91b3f123ed49b8/sandbox/linux-sandbox/243/execroot/salvo/bazel-out/k8-fastbuild/testlogs/_coverage/src/lib/test_cmd_exec/test/.coveragerc
Unknown command: 'lcov'
Use 'coverage help' for help.
--
Coverage runner: Not collecting coverage for failed test.
The following commands failed with status 1
/usr/local/google/home/mumak/.cache/bazel/_bazel_mumak/0692d959e92750360f91b3f123ed49b8/sandbox/linux-sandbox/243/execroot/salvo/bazel-out/k8-fastbuild/bin/src/lib/test_cmd_exec.runfiles/salvo/src/lib/test_cmd_exec
================================================================================

Looks like the workaround from here might no longer work.
@mum4k mum4k self-assigned this Jan 4, 2023
@mum4k mum4k mentioned this issue Jan 4, 2023
Merged
mum4k added a commit that referenced this issue Jan 5, 2023
@mum4k
Disable coverage report until it is fixed. (#186)
79e93de 
Works on #187 

Also include the `System.JobAttempt` in the artifact name to ensure unique artifact names for each retry. This was tested in the Nighthawk repository and will be useful once we re-enable the coverage report.

Signed-off-by: Jakub Sobon <mumak@google.com>
@github-actions
Copy link

github-actions bot commented Apr 5, 2023

This issue has been automatically marked as stale because it has not had activity in the last 90 days. It will be closed in the next 14 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Apr 5, 2023
@github-actions
Copy link

This issue has been automatically closed because it has not had activity in the last 104 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 20, 2023
@gyohuangxin
Copy link
Member

IMO, this issue is still not resolved.

@gyohuangxin gyohuangxin reopened this Apr 20, 2023
@mum4k mum4k added the no stalebot Exempts an issue or a PR from the stalebot. label Apr 20, 2023
@github-actions github-actions bot removed the stale label Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mum4k mum4k

Labels
no stalebot Exempts an issue or a PR from the stalebot.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mum4k @gyohuangxin