Skip to content

Commit

Permalink
verbose assert message
Browse files Browse the repository at this point in the history
Signed-off-by: Jose Nino <jnino@lyft.com>
  • Loading branch information
Jose Nino committed Sep 30, 2020
1 parent 6f14724 commit 40b40e4
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions source/common/event/dispatcher_impl.cc
Original file line number Diff line number Diff line change
Expand Up @@ -133,10 +133,13 @@ Network::DnsResolverSharedPtr DispatcherImpl::createDnsResolver(
RELEASE_ASSERT(
resolvers.empty(),
"defining custom resolvers is not possible when using Apple APIs for DNS resolution. "
"Apple's API only allows overriding DNS resolvers via system settings.");
"Apple's API only allows overriding DNS resolvers via system settings. Delete resolvers "
"config or disable the envoy.restart_features.use_apple_api_for_dns_lookups runtime "
"feature.");
RELEASE_ASSERT(!use_tcp_for_dns_lookups,
"using TCP for DNS lookups is not possible when using Apple APIs for DNS "
"resolution. Apple' API only uses UDP for DNS resolution");
"resolution. Apple' API only uses UDP for DNS resolution. Use UDP or disable "
"the envoy.restart_features.use_apple_api_for_dns_lookups runtime feature.");
return Network::DnsResolverSharedPtr{new Network::AppleDnsResolverImpl(*this)};
}
#endif
Expand Down

0 comments on commit 40b40e4

Please sign in to comment.