Skip to content

Commit

Permalink
docs: create sections for ACK/NACK and versioning
Browse files Browse the repository at this point in the history
Signed-off-by: Sanjay Pujare <sanjaypujare@users.noreply.github.com>
  • Loading branch information
sanjaypujare committed Dec 16, 2019
1 parent 30396a4 commit 4d9658d
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion api/xds_protocol.rst
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,8 @@ After a NACK, an API update may succeed at a new version **Y**:
.. figure:: diagrams/later-ack.svg
:alt: ACK after NACK

ACK and NACK semantics can be summarized as follows:
ACK and NACK semantics summary
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

- The xDS client should ACK or NACK every :ref:`DiscoveryResponse <envoy_api_msg_DiscoveryResponse>`
received from the management server.
Expand All @@ -290,6 +291,9 @@ ACK and NACK semantics can be summarized as follows:
:ref:`version_info <envoy_api_field_DiscoveryResponse.version_info>`.
- Only the NACK should populate the :ref:`error_detail <envoy_api_field_DiscoveryRequest.error_detail>`.

Versioning and Node Identifier
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Each stream has its own notion of versioning, there is no shared
versioning across resource types. When ADS is not used, even each
resource of a given resource type may have a distinct version, since the
Expand Down

0 comments on commit 4d9658d

Please sign in to comment.