Skip to content

Commit

Permalink
disabling proof of concept test
Browse files Browse the repository at this point in the history
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
  • Loading branch information
alyssawilk committed Aug 28, 2018
1 parent 8745ebd commit 580e760
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion test/common/router/header_formatter_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,10 @@ TEST_F(RequestInfoHeaderFormatterTest, TestFormatWithUpstreamMetadataVariable) {
testFormatting(request_info, "UPSTREAM_METADATA([\"namespace\", \"nested\", \"list_key\"])", "");
}

TEST_F(RequestInfoHeaderFormatterTest, UserDefinedHeadersConsideredHarmful) {
// Breaks tsan/asan builds by trying to allocate a lot of memory.
// Works on debug builds and needs to be fixed. See
// https://github.com/envoyproxy/envoy/issues/4268
TEST_F(RequestInfoHeaderFormatterTest, DISABLED_UserDefinedHeadersConsideredHarmful) {
// This must be an inline header to get the append-in-place semantics.
const char* header_name = "connection";
Protobuf::RepeatedPtrField<envoy::api::v2::core::HeaderValueOption> to_add;
Expand Down

0 comments on commit 580e760

Please sign in to comment.