clang-tidy: bugprone-unused-raii (#7605)

Signed-off-by: Derek Argueta <dereka@pinterest.com>
envoyproxy · Jul 17, 2019 · 5e95cc3 · 5e95cc3
1 parent a8e1364
commit 5e95cc3
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/.clang-tidy b/.clang-tidy
@@ -17,6 +17,7 @@ WarningsAsErrors: 'abseil-duration-*,
                    abseil-string-find-startswith,
                    abseil-upgrade-duration-conversions,
                    bugprone-assert-side-effect,
+                   bugprone-unused-raii,
                    bugprone-use-after-move,
                    modernize-make-shared,
                    modernize-make-unique,

diff --git a/test/common/stats/tag_producer_impl_test.cc b/test/common/stats/tag_producer_impl_test.cc
@@ -17,7 +17,7 @@ TEST(TagProducerTest, CheckConstructor) {
   auto& tag_specifier1 = *stats_config.mutable_stats_tags()->Add();
   tag_specifier1.set_tag_name("test.x");
   tag_specifier1.set_fixed_value("xxx");
-  TagProducerImpl{stats_config};
+  EXPECT_NO_THROW(TagProducerImpl{stats_config});
 
   // Should raise an error when duplicate tag names are specified.
   auto& tag_specifier2 = *stats_config.mutable_stats_tags()->Add();