Reuse response object as expected values

Signed-off-by: Dhi Aurrahman <dio@rockybars.com>
envoyproxy · Jul 13, 2018 · 9403723 · 9403723
1 parent 40d9b3f
commit 9403723
Showing 1 changed file with 4 additions and 10 deletions.
diff --git a/test/extensions/filters/http/grpc_json_transcoder/json_transcoder_filter_test.cc b/test/extensions/filters/http/grpc_json_transcoder/json_transcoder_filter_test.cc
@@ -577,13 +577,10 @@ TEST_F(GrpcJsonTranscoderFilterTest, TranscodingUnaryWithHttpBodyAsOutput) {
   EXPECT_EQ(Http::FilterDataStatus::StopIterationAndBuffer,
             filter_.encodeData(*response_data, false));
 
-  const std::string response_html = response_data->toString();
-
-  EXPECT_EQ("text/html", response_headers.get_("content-type"));
-  EXPECT_EQ("<h1>Hello, world!</h1>", response_html);
+  EXPECT_EQ(response.content_type(), response_headers.get_("content-type"));
+  EXPECT_EQ(response.data(), response_data->toString());
 
   Http::TestHeaderMapImpl response_trailers{{"grpc-status", "0"}, {"grpc-message", ""}};
-
   EXPECT_EQ(Http::FilterTrailersStatus::Continue, filter_.decodeTrailers(response_trailers));
 }
 
@@ -624,13 +621,10 @@ TEST_F(GrpcJsonTranscoderFilterTest, TranscodingUnaryWithHttpBodyAsOutputAndSpli
   EXPECT_EQ(Http::FilterDataStatus::StopIterationAndBuffer,
             filter_.encodeData(*response_data, false));
 
-  const std::string response_html = response_data->toString();
-
-  EXPECT_EQ("text/html", response_headers.get_("content-type"));
-  EXPECT_EQ("<h1>Hello, world!</h1>", response_html);
+  EXPECT_EQ(response.content_type(), response_headers.get_("content-type"));
+  EXPECT_EQ(response.data(), response_data->toString());
 
   Http::TestHeaderMapImpl response_trailers{{"grpc-status", "0"}, {"grpc-message", ""}};
-
   EXPECT_EQ(Http::FilterTrailersStatus::Continue, filter_.decodeTrailers(response_trailers));
 }