Skip to content

Commit

Permalink
remove unused variables (#4013)
Browse files Browse the repository at this point in the history
Signed-off-by: Rama <rama.rao@salesforce.com>
  • Loading branch information
ramaraochavali authored and mattklein123 committed Aug 1, 2018
1 parent e999cfa commit aec9223
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions source/common/stats/thread_local_store.cc
Original file line number Diff line number Diff line change
Expand Up @@ -67,14 +67,12 @@ std::vector<GaugeSharedPtr> ThreadLocalStoreImpl::gauges() const {
}

std::vector<ParentHistogramSharedPtr> ThreadLocalStoreImpl::histograms() const {
// Handle de-dup due to overlapping scopes.
std::vector<ParentHistogramSharedPtr> ret;
std::unordered_set<std::string> names;
Thread::LockGuard lock(lock_);
// TODO(ramaraochavali): As histograms don't share storage, there is a chance of duplicate names
// here. We need to create global storage for histograms similar to how we have a central storage
// in shared memory for counters/gauges. In the interim, no de-dup is done here. This may result
// in histograms with duplicate names, but until shared storage is implementing it's ultimately
// in histograms with duplicate names, but until shared storage is implemented it's ultimately
// less confusing for users who have such configs.
for (ScopeImpl* scope : scopes_) {
for (const auto& name_histogram_pair : scope->central_cache_.histograms_) {
Expand Down

0 comments on commit aec9223

Please sign in to comment.