Skip to content

Commit

Permalink
Revert "ci: revert EngFlow ios_build changes (#1700)" (#1704)
Browse files Browse the repository at this point in the history
Description: This reverts commit c1ef46d4c62dd94a4a7a22c83e22fa6c99534be9.

The machine was running out of space because it was keeping large replicas of build artifacts for too long. We've since increased the disk space as well as decreased the timeout for evicting those large artifacts. Performance may be slightly degraded if those artifacts need to go to disk to be fetched but by looking at previous results it'll probably be ok

Risk Level: Low
Testing: See ios_build presubmit
Docs Changes: N/A
Release Notes: N/A

Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: JP Simard <jp@jpsim.com>
  • Loading branch information
lfpino authored and jpsim committed Nov 29, 2022
1 parent 2860a93 commit b77e9a3
Showing 1 changed file with 12 additions and 27 deletions.
39 changes: 12 additions & 27 deletions mobile/.github/workflows/ios_build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,29 +27,6 @@ jobs:
- run: ./ci/mac_ci_setup.sh
if: steps.check-cache.outputs.cache-hit != 'true'
name: 'Install dependencies'
- run: bazelisk build --config=ios //:ios_dist
if: steps.check-cache.outputs.cache-hit != 'true'
name: 'Build Envoy.framework distributable'
iosbuildshadow:
name: ios_build_shadow
runs-on: macOS-latest
timeout-minutes: 75
steps:
- uses: actions/checkout@v1
with:
submodules: true
- uses: actions/cache@v2
id: check-cache
with:
key: framework-shadow-${{ github.sha }}
path: dist/Envoy.framework
name: 'Check cache'
- run: echo "Found Envoy.framework from previous run!"
if: steps.check-cache.outputs.cache-hit == 'true'
name: 'Build cache hit'
- run: ./ci/mac_ci_setup.sh
if: steps.check-cache.outputs.cache-hit != 'true'
name: 'Install dependencies'
- env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
Expand Down Expand Up @@ -77,10 +54,14 @@ jobs:
- run: exit 1
if: steps.check-cache.outputs.cache-hit != 'true'
name: 'Short-circuit'
- run: bazelisk build --config=ios //examples/swift/hello_world:app
- env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: bazelisk build --config=ios --config=remote-ci-macos --remote_header="Authorization=Bearer $GITHUB_TOKEN" //examples/swift/hello_world:app
name: 'Build swift app'
# Run the app in the background and redirect logs.
- run: bazelisk run --config=ios //examples/swift/hello_world:app &> /tmp/envoy.log &
- env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: bazelisk run --config=ios --config=remote-ci-macos --remote_header="Authorization=Bearer $GITHUB_TOKEN" //examples/swift/hello_world:app &> /tmp/envoy.log &
name: 'Run swift app'
- run: sed '/received headers with status 200/q' <(touch /tmp/envoy.log && tail -F /tmp/envoy.log)
name: 'Check connectivity'
Expand All @@ -107,10 +88,14 @@ jobs:
- run: exit 1
if: steps.check-cache.outputs.cache-hit != 'true'
name: 'Short-circuit'
- run: bazelisk build --config=ios //examples/objective-c/hello_world:app
- env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: bazelisk build --config=ios --config=remote-ci-macos --remote_header="Authorization=Bearer $GITHUB_TOKEN" //examples/objective-c/hello_world:app
name: 'Build objective-c app'
# Run the app in the background and redirect logs.
- run: bazelisk run --config=ios //examples/objective-c/hello_world:app &> /tmp/envoy.log &
- env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: bazelisk run --config=ios --config=remote-ci-macos --remote_header="Authorization=Bearer $GITHUB_TOKEN" //examples/objective-c/hello_world:app &> /tmp/envoy.log &
name: 'Run objective-c app'
- run: sed '/received headers with status 200/q' <(touch /tmp/envoy.log && tail -F /tmp/envoy.log)
name: 'Check connectivity'
Expand Down

0 comments on commit b77e9a3

Please sign in to comment.