Skip to content

Commit

Permalink
android: fixate api_level to be 29 (#918)
Browse files Browse the repository at this point in the history
Fixing android's api to 29 since it seems like api 30 has some bazel proguard issues which are similar to: bazelbuild/bazel#3777

For an explanation of how to fill out the fields, please see the relevant section
in [PULL_REQUESTS.md](https://github.com/envoyproxy/envoy/blob/master/PULL_REQUESTS.md)

Description: android: fixate api_level to be 29
Risk Level: low
Testing: ci
Docs Changes: n/a
Release Notes: n/a
[Optional Fixes #Issue]
[Optional Deprecated:]

Signed-off-by: JP Simard <jp@jpsim.com>
  • Loading branch information
Alan Chiu authored and jpsim committed Nov 29, 2022
1 parent 7e91f61 commit c32485a
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion mobile/WORKSPACE
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ envoy_mobile_dependencies()
load("@envoy_mobile//bazel:envoy_mobile_toolchains.bzl", "envoy_mobile_toolchains")
envoy_mobile_toolchains()

android_sdk_repository(name = "androidsdk")
# Fixing to API 29 since proguard seems to be failing for 30+
android_sdk_repository(name = "androidsdk", api_level = 29)

android_ndk_repository(name = "androidndk")

0 comments on commit c32485a

Please sign in to comment.