Skip to content

Commit

Permalink
test flake: fix header casing integration test (#9104)
Browse files Browse the repository at this point in the history
Given that most other integration tests don't set a timeout for
an upstream connection that is expected to succeed, remove the
timeout.

Risk Level: low, test-only
Testing: 1000 repetitions
Doc Changes: n/a
Release Notes: n/a
Fixes: #8899

Signed-off-by: Stephan Zuercher <zuercher@gmail.com>
  • Loading branch information
zuercher authored and lizan committed Nov 22, 2019
1 parent 40970bd commit cddf4ac
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions test/integration/header_casing_integration_test.cc
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
#include <chrono>

#include "envoy/config/bootstrap/v2/bootstrap.pb.h"

#include "common/buffer/buffer_impl.h"
Expand Down Expand Up @@ -51,8 +49,7 @@ TEST_P(HeaderCasingIntegrationTest, VerifyCasedHeaders) {
tcp_client->write(request, false);

Envoy::FakeRawConnectionPtr upstream_connection;
ASSERT_TRUE(
fake_upstreams_[0]->waitForRawConnection(upstream_connection, std::chrono::milliseconds(10)));
ASSERT_TRUE(fake_upstreams_[0]->waitForRawConnection(upstream_connection));

// Verify that the upstream request has proper cased headers.
std::string upstream_request;
Expand All @@ -74,4 +71,4 @@ TEST_P(HeaderCasingIntegrationTest, VerifyCasedHeaders) {
tcp_client->close();
}

} // namespace Envoy
} // namespace Envoy

0 comments on commit cddf4ac

Please sign in to comment.