You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Title: include rate limit names in global rate limiter response
Description:
The proposal is to update api/envoy/service/ratelimit/v3/rls.proto to add a name, description, or id field to the "RateLimit" message.
This RateLimit message isn't used by envoy today. It seems to be purely information to direct clients of the API (not through envoy), presumably to aid with debugging or support non-envoy clients that might interpret the detailed breakdown of rate limits impacting a request.
Here's a sketch of a rate limit response with the new proposed field:
Some examples of public APIs that have a similar concept of naming or describing which rate limit you've hit:
The AdWords API provides "rateScope" and "rateName" to clients when they hit a rate limit, which could theoretically be expressed as a name.
The FB Marketing API has an "X-Business-Use-Case" response header which provide rate limit details by account & type, which could theoretically be expressed through a name. Maybe as a human-readable or json blob with with all the information.
The text was updated successfully, but these errors were encountered:
This part of the global rate limiter api is not currently used by envoy, but for anyone implementing the envoy global rate limiter api being able to describe what specific limit you've hit in a human-readable and/or machine-readable way will be useful for debugging, alerting, etc.
See envoyproxy#10556
Signed-off-by: David Weitzman <dweitzman@pinterest.com>
…10557)
This part of the global rate limiter api is not currently used by envoy, but for anyone implementing the envoy global rate limiter api being able to describe what specific limit you've hit in a human-readable and/or machine-readable way will be useful for debugging, alerting, etc.
Risk Level: Low
Testing: n/a
Docs Changes: n/a
Release Notes: n/a
Fixes#10556
Signed-off-by: David Weitzman <dweitzman@pinterest.com>
Title: include rate limit names in global rate limiter response
Description:
The proposal is to update api/envoy/service/ratelimit/v3/rls.proto to add a name, description, or id field to the "RateLimit" message.
This RateLimit message isn't used by envoy today. It seems to be purely information to direct clients of the API (not through envoy), presumably to aid with debugging or support non-envoy clients that might interpret the detailed breakdown of rate limits impacting a request.
Here's a sketch of a rate limit response with the new proposed field:
[Relevant Links:]
Some examples of public APIs that have a similar concept of naming or describing which rate limit you've hit:
The AdWords API provides "rateScope" and "rateName" to clients when they hit a rate limit, which could theoretically be expressed as a name.
The FB Marketing API has an "X-Business-Use-Case" response header which provide rate limit details by account & type, which could theoretically be expressed through a name. Maybe as a human-readable or json blob with with all the information.
The text was updated successfully, but these errors were encountered: