Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve changelog linting #22222

Closed
phlax opened this issue Jul 15, 2022 · 3 comments · Fixed by #23708
Closed

Improve changelog linting #22222

phlax opened this issue Jul 15, 2022 · 3 comments · Fixed by #23708
Assignees
Labels
area/release bug enhancement Feature requests. Not bugs or questions. no stalebot Disables stalebot from closing an issue

Comments

@phlax
Copy link
Member

phlax commented Jul 15, 2022

A couple of issues are cropping up in the changelog files

Currently it doesnt check for the text type (ie missing |) on the change strings

there is also a regression where it no longer checks for capitalization on the first word

there may be others that we want to add


  • check structure of changelogs - ie have area/change for every entry
  • prevent editing of historical changelogs
@phlax phlax added the triage Issue requires triage label Jul 15, 2022
@phlax
Copy link
Member Author

phlax commented Jul 15, 2022

cc @alyssawilk

@phlax phlax added bug enhancement Feature requests. Not bugs or questions. area/release and removed triage Issue requires triage labels Jul 15, 2022
@adisuissa
Copy link
Contributor

Related issue: #22237

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Aug 21, 2022
@phlax phlax added no stalebot Disables stalebot from closing an issue and removed stale stalebot believes this issue/PR has not been touched recently labels Aug 23, 2022
@phlax phlax added this to the 1.24.0 milestone Sep 28, 2022
@phlax phlax removed this from the 1.24.0 milestone Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/release bug enhancement Feature requests. Not bugs or questions. no stalebot Disables stalebot from closing an issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants