Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repo: Yaml cleanups #23654

Merged
merged 1 commit into from
Nov 1, 2022
Merged

repo: Yaml cleanups #23654

merged 1 commit into from
Nov 1, 2022

Conversation

phlax
Copy link
Member

@phlax phlax commented Oct 25, 2022

This is an initial cleanup PR ahead of addressing envoyproxy/toolshed#267 to resolve #23348 and #22222

Signed-off-by: Ryan Northey ryan@synca.io

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@phlax phlax requested a review from ggreenway as a code owner October 25, 2022 15:57
@phlax phlax marked this pull request as draft October 25, 2022 15:57
@phlax phlax changed the title [WIP] repo: Yaml cleanups repo: Yaml cleanups Oct 26, 2022
@phlax phlax marked this pull request as ready for review October 26, 2022 07:43
@phlax phlax marked this pull request as draft October 26, 2022 19:26
@phlax phlax changed the title repo: Yaml cleanups [WI{] repo: Yaml cleanups Oct 26, 2022
@phlax phlax changed the title [WI{] repo: Yaml cleanups [WIP] repo: Yaml cleanups Oct 26, 2022
@phlax phlax changed the title [WIP] repo: Yaml cleanups repo: Yaml cleanups Oct 26, 2022
@phlax phlax force-pushed the repo-yaml-lint branch 2 times, most recently from 3dfa287 to 4ae07ae Compare October 26, 2022 19:37
@phlax phlax marked this pull request as ready for review October 26, 2022 19:38
@phlax phlax mentioned this pull request Oct 27, 2022
@wrowe
Copy link
Contributor

wrowe commented Oct 28, 2022

/assign @ggreenway

@phlax
Copy link
Member Author

phlax commented Oct 28, 2022

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #23654 (comment) was created by @phlax.

see: more, trace.

Signed-off-by: Ryan Northey <ryan@synca.io>
Copy link
Contributor

@adisuissa adisuissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@phlax phlax merged commit 9a3b541 into envoyproxy:main Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improved runtime guard checks
4 participants