Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v1.7.0 deprecation] Remove features marked deprecated in #2993 #3713

Closed
alyssawilk opened this issue Jun 25, 2018 · 2 comments
Closed

[v1.7.0 deprecation] Remove features marked deprecated in #2993 #3713

alyssawilk opened this issue Jun 25, 2018 · 2 comments
Assignees
@dio
Labels
deprecation Feature deprecation tracking tech debt
Milestone
1.8.0

Comments

@alyssawilk
Copy link
Contributor

#2993 (health check: add Redis custom health checker) introduced a deprecation notice for v1.7.0. This issue tracks source code cleanup.
@alyssawilk alyssawilk added this to the 1.8.0 milestone Jun 25, 2018
@alyssawilk alyssawilk added deprecation Feature deprecation tracking tech debt labels Jun 25, 2018
@dio
Copy link
Member

dio commented Jun 26, 2018

@alyssawilk should I remove the warning logging only? Since I'm not sure we want to remove "RedisHealthCheck" health checker completely.

https://github.com/dio/envoy/blob/b76a69ccb73d7b6abc5e5e48bb38a92744a38ed3/source/common/upstream/health_checker_impl.cc#L57-L59

@mattklein123
Copy link
Member

@dio I think the idea is to deprecate the redis specific config, and only allow driving it via the custom health checker config.

@dio dio mentioned this issue Jul 19, 2018
Merged
mattklein123 pushed a commit that referenced this issue Jul 19, 2018
@dio @mattklein123
Remove the deprecated redis_health_check field (#3896)
b202f89 
Fixes #3713

Signed-off-by: Dhi Aurrahman <dio@rockybars.com>
mattklein123 pushed a commit to envoyproxy/data-plane-api that referenced this issue Jul 19, 2018
Remove the deprecated redis_health_check field (#3896)
9470c89 
Fixes envoyproxy/envoy#3713

Signed-off-by: Dhi Aurrahman <dio@rockybars.com>

Mirrored from https://github.com/envoyproxy/envoy @ b202f894fd24c96309e71657c9a033a08bd99415
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dio dio

Labels
deprecation Feature deprecation tracking tech debt
Projects
None yet
Milestone
1.8.0
Development

No branches or pull requests
3 participants
@dio @mattklein123 @alyssawilk