Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move redis to TCP connection pool #3818

Open
2 of 4 tasks
zuercher opened this issue Jul 9, 2018 · 6 comments
Open
2 of 4 tasks

move redis to TCP connection pool #3818

zuercher opened this issue Jul 9, 2018 · 6 comments
Assignees
@zuercher
Labels
area/redis help wanted Needs help! tech debt

Comments

@zuercher
Copy link
Member

zuercher commented Jul 9, 2018 •
edited by alyssawilk
Loading

Tracking ticket for follow-on modifications related to the generic TCP connection pool, per discussion in #3747:

  • refactor HTTP1 connection pool to extend it
  • modify tcp_proxy to use connection pool vs. tcpConnForCluster
  • modify redis_proxy to use connection pool

Other possible lines of inquiry:
@zuercher zuercher self-assigned this Jul 9, 2018
@zuercher zuercher mentioned this issue Jul 9, 2018
Merged
zuercher added a commit to turbinelabs/envoy that referenced this issue Jul 19, 2018
@zuercher
tcp/conn_pool: improve interface for callers
d0677cc 
Provides additional pool failure reasons to allow Tcp::ConnectionPool
callers to distinguish between time outs and connection failures.
Passes through connection and buffer watermark events.

A subsequent PR will switch the TCP proxy to use the TCP connection
pool (and makes use of these features). Relates to envoyproxy#3818.

*Risk Level*: low
*Testing*: unit tests
*Docs Changes*: n/a
*Release Notes*: n/a

Signed-off-by: Stephan Zuercher <stephan@turbinelabs.io>
@zuercher zuercher mentioned this issue Jul 19, 2018
Merged
@zuercher
Copy link
Member Author

#3903 makes some additional conn pool changes needed to adapt TCP Proxy.

zuercher added a commit that referenced this issue Jul 23, 2018
@zuercher
tcp/conn_pool: improve interface for callers (#3903)
7c11e92 
tcp/conn_pool: improve interface for callers

Provides additional pool failure reasons to allow Tcp::ConnectionPool
callers to distinguish between time outs and connection failures.
Passes through connection and buffer watermark events.

A subsequent PR will switch the TCP proxy to use the TCP connection
pool (and makes use of these features). Relates to #3818.

*Risk Level*: low
*Testing*: unit tests
*Docs Changes*: n/a
*Release Notes*: n/a

Signed-off-by: Stephan Zuercher <stephan@turbinelabs.io>
@zuercher zuercher mentioned this issue Jul 23, 2018
Merged
@zuercher
Copy link
Member Author

#3938 converts the TCP Proxy to use the connection pool.

@stale
Copy link

stale bot commented Aug 29, 2018

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or other activity occurs. Thank you for your contributions.

@stale stale bot added the stale stalebot believes this issue/PR has not been touched recently label Aug 29, 2018
@zuercher zuercher added the no stalebot Disables stalebot from closing an issue label Aug 29, 2018
@stale stale bot removed the stale stalebot believes this issue/PR has not been touched recently label Aug 29, 2018
@zuercher
Copy link
Member Author

This is a background task for me, but I am still working on it.

@tw-bert tw-bert mentioned this issue Mar 12, 2019
Open
@mattklein123
Copy link
Member

@alyssawilk is this issue basically done? I think you now share most of the conn pool logic?

@alyssawilk
Copy link
Contributor

Except for actually using it, yeah.
I'll leave it assigned to me and close it once we've sorted out the latest pinterst report and flipped it back.

@alyssawilk alyssawilk mentioned this issue Jan 12, 2021
Closed
@alyssawilk alyssawilk removed their assignment May 20, 2021
@alyssawilk alyssawilk changed the title TCP connection pool move redis to TCP connection pool May 20, 2021
@mattklein123 mattklein123 added help wanted Needs help! and removed no stalebot Disables stalebot from closing an issue labels Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zuercher zuercher

Labels
area/redis help wanted Needs help! tech debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tcp_proxy: switching to the new pool alyssawilk/envoy
3 participants
@zuercher @mattklein123 @alyssawilk