Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime feature guarding deprecation #6472

Closed
alyssawilk opened this issue Apr 3, 2019 · 2 comments · Fixed by #7493
Closed

runtime feature guarding deprecation #6472

alyssawilk opened this issue Apr 3, 2019 · 2 comments · Fixed by #7493
Assignees
@alyssawilk
Labels
enhancement Feature requests. Not bugs or questions. no stalebot Disables stalebot from closing an issue

Comments

@alyssawilk
Copy link
Contributor

(tracking bug to finish up the bits not done in #5693)
@alyssawilk alyssawilk added enhancement Feature requests. Not bugs or questions. no stalebot Disables stalebot from closing an issue labels Apr 3, 2019
@alyssawilk alyssawilk added this to the 1.11.0 milestone Apr 3, 2019
@alyssawilk alyssawilk self-assigned this Apr 3, 2019
@mattklein123
Copy link
Member

@alyssawilk just for tracking what is left here? Script updates?

@alyssawilk
Copy link
Contributor Author

script updates and extending the runtime_features structures I think. I plan on picking it up this or next week now we have a use case :-)

@alyssawilk alyssawilk mentioned this issue Jul 8, 2019
Merged
@alyssawilk alyssawilk removed this from the 1.11.0 milestone Jul 10, 2019
alyssawilk added a commit that referenced this issue Jul 11, 2019
@alyssawilk
tools: update our release scripts (#7493)
e75ff19 
Functionally this

removes the script which filed bugs to remove old config (per plan of record in #6271)
adds a script which files bugs to remove old code (cleanup of runtime guarded features)
updates our release process
In practice, this just hot swaps what our deprecation script does and updates the docs.

Risk Level: n/a (tooling + comment)
Testing: manual testing. Will do one more manual test with actual bug filing just before submitting.
Docs Changes: updated
Release Notes: n/a
Fixes #6472

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alyssawilk alyssawilk

Labels
enhancement Feature requests. Not bugs or questions. no stalebot Disables stalebot from closing an issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tools: update our release scripts alyssawilk/envoy
2 participants
@mattklein123 @alyssawilk