Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node enhancements for stable Envoy versioning #8332

Closed
htuch opened this issue Sep 23, 2019 · 1 comment · Fixed by #9301
Closed

Node enhancements for stable Envoy versioning #8332

htuch opened this issue Sep 23, 2019 · 1 comment · Fixed by #9301
Assignees
@yanavlasov
Labels
api/v3 Major version release @ end of Q3 2019 no stalebot Disables stalebot from closing an issue
Milestone
1.13.0

Comments

@htuch
Copy link
Member

htuch commented Sep 23, 2019

As per #6271, we want Node to report:

  • API semantic version
  • User agent and version
  • Client capabilities
  • Extensions (including extension version information)

Splitting to a separate task for tracking purposes.
@htuch htuch added the api/v3 Major version release @ end of Q3 2019 label Sep 23, 2019
@htuch htuch added this to the 1.12.0 milestone Sep 23, 2019
@htuch htuch added help wanted Needs help! and removed help wanted Needs help! labels Sep 23, 2019
@htuch htuch removed this from the 1.12.0 milestone Sep 27, 2019
@stale
Copy link

stale bot commented Oct 27, 2019

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or other activity occurs. Thank you for your contributions.

@stale stale bot added the stale stalebot believes this issue/PR has not been touched recently label Oct 27, 2019
@htuch htuch added no stalebot Disables stalebot from closing an issue and removed stale stalebot believes this issue/PR has not been touched recently labels Oct 28, 2019
@htuch htuch added this to the 1.13.0 milestone Nov 21, 2019
@lizan lizan mentioned this issue Dec 5, 2019
Open
@jpeach jpeach mentioned this issue Dec 5, 2019
Closed
@yanavlasov yanavlasov mentioned this issue Dec 10, 2019
Merged
This was referenced Dec 19, 2019
Closed
Closed
htuch pushed a commit that referenced this issue Jan 8, 2020
@yanavlasov @htuch
API: Add extension information the Node message. (#9301)
f5efe4a 
Report extension information in the Node message.

Risk Level: Low
Testing: Unit Tests
Docs Changes: N/A
Release Notes: N/A

Fixes: #8332

Signed-off-by: Yan Avlasov <yavlasov@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yanavlasov yanavlasov

Labels
api/v3 Major version release @ end of Q3 2019 no stalebot Disables stalebot from closing an issue
Projects
None yet
Milestone
1.13.0
Development

Successfully merging a pull request may close this issue.

API: Add extension information the Node message. yanavlasov/envoy
2 participants
@yanavlasov @htuch