Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix SNI FAQ link #10227

Merged
merged 1 commit into from
Mar 2, 2020
Merged

doc: fix SNI FAQ link #10227

merged 1 commit into from
Mar 2, 2020

Conversation

lizan
Copy link
Member

@lizan lizan commented Mar 2, 2020

Fixes #10225
Signed-off-by: Lizan Zhou lizan@tetrate.io

Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@mattklein123 mattklein123 merged commit a9b9f8b into envoyproxy:master Mar 2, 2020
lizan added a commit that referenced this pull request Mar 3, 2020
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
htuch pushed a commit that referenced this pull request Jul 9, 2020
…resumes requests on destruction. (#11739)

* doc: fix SNI FAQ link (#10227)

Signed-off-by: Lizan Zhou <lizan@tetrate.io>

* make api pause/resume in pair by returning a RAII obj which resumes requests on destruction

Signed-off-by: Xin Zhuang <stevenzzz@google.com>

* cancel resume_cds_ on shutdown of clustermanagerImpl

Signed-off-by: Xin Zhuang <stevenzzz@google.com>

* format errors fix

Signed-off-by: Xin Zhuang <stevenzzz@google.com>

* move the ABSL_MUST_USE_RESULT attr to the beginning to see if gcc will be happy

Signed-off-by: Xin Zhuang <stevenzzz@google.com>

* pass by reference type_urls into cleanup in scoped rds

Signed-off-by: Xin Zhuang <stevenzzz@google.com>

* review fixes per Harvey comments.

Signed-off-by: Xin Zhuang <stevenzzz@google.com>

* remove unused parameter, weird it wasnt caught previously

Signed-off-by: Xin Zhuang <stevenzzz@google.com>

* fix-format using clang 10

Signed-off-by: Xin Zhuang <stevenzzz@google.com>

Co-authored-by: Lizan Zhou <lizan@tetrate.io>
scheler pushed a commit to scheler/envoy that referenced this pull request Aug 4, 2020
…resumes requests on destruction. (envoyproxy#11739)

* doc: fix SNI FAQ link (envoyproxy#10227)

Signed-off-by: Lizan Zhou <lizan@tetrate.io>

* make api pause/resume in pair by returning a RAII obj which resumes requests on destruction

Signed-off-by: Xin Zhuang <stevenzzz@google.com>

* cancel resume_cds_ on shutdown of clustermanagerImpl

Signed-off-by: Xin Zhuang <stevenzzz@google.com>

* format errors fix

Signed-off-by: Xin Zhuang <stevenzzz@google.com>

* move the ABSL_MUST_USE_RESULT attr to the beginning to see if gcc will be happy

Signed-off-by: Xin Zhuang <stevenzzz@google.com>

* pass by reference type_urls into cleanup in scoped rds

Signed-off-by: Xin Zhuang <stevenzzz@google.com>

* review fixes per Harvey comments.

Signed-off-by: Xin Zhuang <stevenzzz@google.com>

* remove unused parameter, weird it wasnt caught previously

Signed-off-by: Xin Zhuang <stevenzzz@google.com>

* fix-format using clang 10

Signed-off-by: Xin Zhuang <stevenzzz@google.com>

Co-authored-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: scheler <santosh.cheler@appdynamics.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken SNI config links in the latest published version of the docs
2 participants