xds: envoy-api external dependency. #1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds an envoy_cc_api target to consume the v2 xDS API protos, and a dummy target that will be the basis of some early EDS prototyping work.
junr03
reviewed
Jun 2, 2017
| remote = "https://github.com/lyft/envoy-api.git", | ||
| commit = "959278cc35a89a4d2f1895f66a59c6b3de98d5e1", | ||
| ) | ||
| native.bind( |
There was a problem hiding this comment.
should we bind all the different libraries in this PR? Or do you want to bring them one by one as we start migrating to v2?
Should we start some documentation on this for this PR?
There was a problem hiding this comment.
We can do them as needed. I'm really just trying to get a feel for how this will work, so let's leave the doco until later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds an envoy_cc_api target to consume the v2 xDS API protos, and a dummy target that will
be the basis of some early EDS prototyping work.