http/2: correctly handle reset after complete response #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nghttp2 will cancel outgoing frames if a reset frame is submitted before previous headers/data frames are sent. We handle this case by deferring the reset until we actually send the full response.
|
@lyft/network-team |
RomanDzhabarov
approved these changes
Sep 29, 2016
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
rlenglet
referenced
this pull request
in istio/envoy
Aug 13, 2019
…#105) * gRPC and HTTP calls return on RootContext. Add setEffectiveContext() call. Signed-off-by: John Plevyak <jplevyak@gmail.com>
nrjpoddar
pushed a commit
to nrjpoddar/envoy
that referenced
this pull request
Oct 3, 2019
…uster modification (envoyproxy#8106) (envoyproxy#105) Risk Level: Medium Testing: New unit test added. Fix verified via --config=asan. Signed-off-by: Andres Guedez <aguedez@google.com> Signed-off-by: John Plevyak <jplevyak@gmail.com>
shalk
pushed a commit
to shalk/envoy
that referenced
this pull request
Nov 6, 2020
translation intro.rst
jwendell
added a commit
to jwendell/envoy
that referenced
this pull request
Mar 30, 2022
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Signed-off-by: Jose Nino jnino@lyft.com Description: pin our bazel install to 0.26.1. There are a few items that do not work yet on 0.27.0, and we want to have a controlled upgrade. Risk Level: low -- pins the bazel version for ease of compatibility Testing: CI Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Signed-off-by: Jose Nino jnino@lyft.com Description: pin our bazel install to 0.26.1. There are a few items that do not work yet on 0.27.0, and we want to have a controlled upgrade. Risk Level: low -- pins the bazel version for ease of compatibility Testing: CI Signed-off-by: JP Simard <jp@jpsim.com>
arminabf
pushed a commit
to arminabf/envoy
that referenced
this pull request
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nghttp2 will cancel outgoing frames if a reset frame is submitted before
previous headers/data frames are sent. We handle this case by deferring
the reset until we actually send the full response.