Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: small fix #114

Merged
merged 1 commit into from
Oct 3, 2016
Merged

docs: small fix #114

merged 1 commit into from
Oct 3, 2016

Conversation

mattklein123
Copy link
Member

No description provided.

@mattklein123
Copy link
Member Author

@lyft/network-team

junr03
junr03 approved these changes Oct 3, 2016
View reviewed changes
Copy link
Member

@junr03 junr03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see how it should be formatted. Will be more careful next time.

@mattklein123 mattklein123 merged commit 9d97f94 into master Oct 3, 2016
@mattklein123 mattklein123 deleted the fix_docs branch October 3, 2016 19:56
PiotrSikora pushed a commit to PiotrSikora/envoy that referenced this pull request Nov 5, 2019
@howardjohn
Update CODEOWNERS (envoyproxy#114)
f123d8f
lizan pushed a commit that referenced this pull request Mar 3, 2020
@myidpt @lizan
sds: fix combined validation context validation bypassing (#114)
d86f971 
Previously, the update callback was called only when the secret
was received for the first time or when its value changed.

This meant that if the same secret (e.g. trusted CA) was used in
multiple resources, then resources using it but configured after
the secret was already received, remained unconfigured until the
secret's value changed.

The missing callback should have resulted in transport factories
stuck in the "not ready" state, however, because of an incorrect
code, the available secret was processed like inlined validation
context, and only rules from the "secret" part of the validation
context were applied, leading to a complete bypass of rules from
the "default" part.

Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Co-authored-by: Oliver Liu <yonggangl@google.com>
lizan pushed a commit that referenced this pull request Mar 3, 2020
@myidpt @lizan
[1.13] sds: fix combined validation context validation bypassing (#114)
f67a19a 
Previously, the update callback was called only when the secret
was received for the first time or when its value changed.

This meant that if the same secret (e.g. trusted CA) was used in
multiple resources, then resources using it but configured after
the secret was already received, remained unconfigured until the
secret's value changed.

The missing callback should have resulted in transport factories
stuck in the "not ready" state, however, because of an incorrect
code, the available secret was processed like inlined validation
context, and only rules from the "secret" part of the validation
context were applied, leading to a complete bypass of rules from
the "default" part.

Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Co-authored-by: Oliver Liu <yonggangl@google.com>
PiotrSikora pushed a commit to PiotrSikora/envoy that referenced this pull request Mar 3, 2020
@myidpt @PiotrSikora
sds: fix combined validation context validation bypassing (envoyproxy…
5d58f33 
…#114)

Previously, the update callback was called only when the secret
was received for the first time or when its value changed.

This meant that if the same secret (e.g. trusted CA) was used in
multiple resources, then resources using it but configured after
the secret was already received, remained unconfigured until the
secret's value changed.

The missing callback should have resulted in transport factories
stuck in the "not ready" state, however, because of an incorrect
code, the available secret was processed like inlined validation
context, and only rules from the "secret" part of the validation
context were applied, leading to a complete bypass of rules from
the "default" part.

Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Co-authored-by: Oliver Liu <yonggangl@google.com>
PiotrSikora added a commit to PiotrSikora/envoy that referenced this pull request Mar 3, 2020
@PiotrSikora @myidpt
sds: fix combined validation context validation bypassing (envoyproxy…
68d1a87 
…#114) (envoyproxy#174)

Previously, the update callback was called only when the secret
was received for the first time or when its value changed.

This meant that if the same secret (e.g. trusted CA) was used in
multiple resources, then resources using it but configured after
the secret was already received, remained unconfigured until the
secret's value changed.

The missing callback should have resulted in transport factories
stuck in the "not ready" state, however, because of an incorrect
code, the available secret was processed like inlined validation
context, and only rules from the "secret" part of the validation
context were applied, leading to a complete bypass of rules from
the "default" part.

Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Co-authored-by: Oliver Liu <yonggangl@google.com>

Co-authored-by: Oliver Liu <yonggangl@google.com>
wolfguoliang pushed a commit to wolfguoliang/envoy that referenced this pull request Jan 23, 2021
@majinghe
Merge pull request envoyproxy#114 from zhd173/haidong/docs-zh-double-…
5da8893 
…proxy

docs: update deployment types double proxy
arminabf pushed a commit to arminabf/envoy that referenced this pull request Jun 5, 2024
@anuraaga
Update TinyGo fork commit (envoyproxy#114)
92ce998
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junr03 junr03 junr03 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattklein123 @junr03