Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup: cleaning up .first/.second [source/common/config] #12468

Merged
merged 9 commits into from
Aug 10, 2020

Conversation

aimless404
Copy link
Contributor

This is the second PR to this #12354. This time is in the common/config submodule.

Commit Message:
Additional Description:
Risk Level: Low, solely cosmetic changes.
Testing: All existing tests passed.
Docs Changes:
Release Notes:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]

Yifan Yang added 7 commits July 29, 2020 16:50
Signed-off-by: Yifan Yang <needyyang@google.com>
Signed-off-by: Yifan Yang <needyyang@google.com>
Signed-off-by: Yifan Yang <needyyang@google.com>
Signed-off-by: Yifan Yang <needyyang@google.com>
Signed-off-by: Yifan Yang <needyyang@google.com>
Signed-off-by: Yifan Yang <needyyang@google.com>
@aimless404
Copy link
Contributor Author

@junr03 @asraa this has been out here for a while now. Do you mind taking a look?

@junr03
Copy link
Member

junr03 commented Aug 7, 2020

@asraa carries context from #12354 so I will let her take this.

@junr03 junr03 assigned asraa and unassigned junr03 Aug 7, 2020
Copy link
Contributor

@asraa asraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just one small nit, otherwise names look good to me. Nice @ re-using the existing aliases.

source/common/config/new_grpc_mux_impl.cc Outdated Show resolved Hide resolved
Yifan Yang added 2 commits August 7, 2020 20:16
Copy link
Contributor

@asraa asraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants