-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Update x-envoy-upstream-service-time description to be more accurate #12517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wbpcode <comems@msn.com>
Signed-off-by: wbpcode <comems@msn.com>
dio
changed the title
make docs of x-envoy-upstream-service-time more accurate
docs: Update x-envoy-upstream-service-time description to be more accurate
Aug 6, 2020
dio
previously approved these changes
Aug 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
dio
reviewed
Aug 6, 2020
Comment on lines
363
to
364
Contains the time in milliseconds spent by the upstream host processing the request and the network | ||
latency between Envoy and upstream host. This is useful if the client wants to determine service time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Superfluous spaces? Probably setting your editor to trim empty spaces will be helpful.
Signed-off-by: wbpcode <comems@msn.com>
/retest |
🤷♀️ nothing to rebuild. |
It's ok now. |
dio
approved these changes
Aug 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: Update docs of
x-envoy-upstream-service-time
.From the source code,
x-envoy-upstream-service-time
includes the latency of the network from envoy to upstream host and the time cost of upstream host generating responses. But the description in the docs is ambiguous and may lead to confusion in understanding it. Relevant: #12437.envoy/source/common/router/router.cc
Lines 1268 to 1276 in d58bdcf
Risk Level: N/A
Testing: N/A
Docs Changes: Docs only
Release Notes: N/A
Signed-off-by: wbpcode comems@msn.com