Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

abseil: update to latest #12561

Merged
merged 5 commits into from
Aug 10, 2020
Merged

abseil: update to latest #12561

merged 5 commits into from
Aug 10, 2020

Conversation

mattklein123
Copy link
Member

Pulls in TSAN mutex fixes as well as works around false detection.

Signed-off-by: Matt Klein mklein@lyft.com

Risk Level: Low
Testing: Existing tests
Docs Changes: N/A
Release Notes: N/A

Pulls in TSAN mutex fixes as well as works around false detection.

Signed-off-by: Matt Klein <mklein@lyft.com>
@lizan
Copy link
Member

lizan commented Aug 10, 2020

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines, to retry CircleCI checks, use /retest-circle.
Check envoy-presubmit (Linux-x64 compile_time_options) didn't fail.

🐱

Caused by: a #12561 (comment) was created by @lizan.

see: more, trace.

@mattklein123
Copy link
Member Author

I will look at the error here. Oddly I'm not seeing this error on my other branch where I fix a bunch of other things. I will see if I can do a quick fix here to unblock this.

Signed-off-by: Matt Klein <mklein@lyft.com>
Signed-off-by: Matt Klein <mklein@lyft.com>
@mattklein123
Copy link
Member Author

@lizan @jmarantz fixed pre-existing test issue.

jmarantz
jmarantz previously approved these changes Aug 10, 2020
@mattklein123
Copy link
Member Author

I already fixed this latest flake on my next branch, but I guess I should do some type of interim fix here since this will likely flake a lot. This is fun. :(

Signed-off-by: Matt Klein <mklein@lyft.com>
Signed-off-by: Matt Klein <mklein@lyft.com>
@mattklein123 mattklein123 merged commit cce07c0 into master Aug 10, 2020
@mattklein123 mattklein123 deleted the absl_update branch August 10, 2020 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants