On demand loading of ScopedRouteConfiguration

source/common/http/conn_manager_impl.cc

@@ -515,11 +515,9 @@ void ConnectionManagerImpl::RdsRouteConfigUpdateRequester::requestVhdsUpdate(
 void ConnectionManagerImpl::RdsRouteConfigUpdateRequester::requestSrdsUpdate(
     Router::ScopeKeyPtr scope_key, Event::Dispatcher& thread_local_dispatcher,
     Http::RouteConfigUpdatedCallbackSharedPtr route_config_updated_cb) {
-  // If it is inline scope_route_config_provider, will be cast to nullptr.
-  if (scoped_route_config_provider_ == nullptr) {
-    (*route_config_updated_cb)(false);
-    return;
-  }
+  // since inline scope_route_config_provider is not fully implemented and never used,
+  // dynamic cast in constructor always succeed and the pointer should not be null here.
+  ASSERT(scoped_route_config_provider_ != nullptr);
   Http::RouteConfigUpdatedCallback scoped_route_config_updated_cb =
       Http::RouteConfigUpdatedCallback(
           [this, weak_route_config_updated_cb = std::weak_ptr<Http::RouteConfigUpdatedCallback>(

source/common/http/conn_manager_impl.h

@@ -121,8 +121,10 @@ class ConnectionManagerImpl : Logger::Loggable<Logger::Id::http>,
 
     RdsRouteConfigUpdateRequester(Config::ConfigProvider* scoped_route_config_provider,
                                   ActiveStream& parent)
-        // Only on demand update for ScopeRdsConfigProvider is supported.
-        // InlineScopedRoutesConfigProvider will cast to nullptr in this ctor.
+        // Expect the dynamic cast to succeed because only ScopedRdsConfigProvider is fully
+        // implemented. Inline provider will be cast to nullptr here but it is not full implemented
+        // and can't not be used at this point. Should change this implementation if we have a
+        // functional inline scope route provider in the future.
         : scoped_route_config_provider_(
               dynamic_cast<Router::ScopedRdsConfigProvider*>(scoped_route_config_provider)),
           parent_(parent) {}