Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

udpa: context parameter encoding. #12806

Merged
merged 7 commits into from
Sep 10, 2020
Merged

Conversation

htuch
Copy link
Member

@htuch htuch commented Aug 25, 2020

This patch introduces the xDS transport++ context parameter encoding
algorithm.

Risk level: Low
Testing: Unit tests added.

Signed-off-by: Harvey Tuch htuch@google.com

This patch introduces the xDS transport++ context parameter encoding
algorithm.

Risk level: Low
Testing: Unit tests added.

Signed-off-by: Harvey Tuch <htuch@google.com>
@repokitteh-read-only
Copy link

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to api/envoy/.
CC @envoyproxy/api-watchers: FYI only for changes made to api/envoy/.

🐱

Caused by: #12806 was opened by htuch.

see: more, trace.

@htuch
Copy link
Member Author

htuch commented Aug 25, 2020

CC @chaoqin-li1123

@htuch
Copy link
Member Author

htuch commented Sep 8, 2020

@roth @mattklein123 friendly ping when you get a chance.

Copy link
Contributor

@markdroth markdroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good overall. Just one minor suggestion for the test.

markdroth
markdroth previously approved these changes Sep 8, 2020
@repokitteh-read-only repokitteh-read-only bot removed the api label Sep 8, 2020
Signed-off-by: Harvey Tuch <htuch@google.com>
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with small comments, thank you!

/wait

api/envoy/config/bootstrap/v3/bootstrap.proto Show resolved Hide resolved
source/common/config/udpa_context_params.cc Show resolved Hide resolved
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@repokitteh-read-only repokitteh-read-only bot removed the api label Sep 9, 2020
@htuch htuch merged commit 8613b8e into envoyproxy:master Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants